Search found 58 matches

by poserge
Wed Mar 15, 2017 2:38 pm
Forum: Part Design module development
Topic: Attempt to fix part of #2504
Replies: 7
Views: 2334

Re: Attempt to fix part of #2504

I agree that tests are required, I'll add them. Thanks for reviewing.
by poserge
Tue Mar 14, 2017 3:21 am
Forum: Part Design module development
Topic: Attempt to fix part of #2504
Replies: 7
Views: 2334

Re: Attempt to fix part of #2504

Hi,

I think I've fixed Revolve and Groove to accept faces. Here's the link to PR.

P.S. I've opened new PR on this which is probably not the best way of doing PRs.. Should have probably re-opened the initial one and augmented with new commits..
by poserge
Tue Mar 14, 2017 2:48 am
Forum: Archived Pull Requests
Topic: #613 fix unpickable datum planes
Replies: 12
Views: 3891

Re: #613 fix unpickable datum planes

looks like @poserge took a swipe at this in... this is an independent fix. I confirm that it was completely different fix. Also datum objects are not visible when file is saved and re-opened. Is that the issue #2682 - ? It mentions external references, but in my case datum-s are all gone from viewp...
by poserge
Thu Mar 09, 2017 12:59 pm
Forum: Part Design module development
Topic: Attempt to fix part of #2504
Replies: 7
Views: 2334

Re: Attempt to fix part of #2504

Thanks, I'll investigate.

About drag-n-drop -i remember I've fixed something similar viewtopic.php?f=27&t=18975. Is the bug still there?
by poserge
Thu Mar 09, 2017 5:13 am
Forum: Part Design module development
Topic: Attempt to fix part of #2504
Replies: 7
Views: 2334

Attempt to fix part of #2504

Hi, I'm trying to fix #2504 but I'm not sure if it is correct or not. Bug report consist of two parts: 1. undo after migrate is not working properly 2. Revolve and Groove give errors when applied to a face. This PR fixes second part and it is done by not allowing Revolve and Groove to be applied to ...
by poserge
Mon Mar 06, 2017 5:39 am
Forum: Part Design module development
Topic: What should happen when features is about to be applied outside the body?
Replies: 6
Views: 2292

Re: What should happen when features is about to be applied outside the body?

Hi, I've changed the way workflow is checked in the Primitive, ProfileBased, Transform and Dressup features. It does not allow to add any of these features if document is not in modern workflow mode. Also I've added new checks to ensure Transform and Dressups only applied to single selected objects ...
by poserge
Wed Mar 01, 2017 6:07 am
Forum: Part Design module development
Topic: What should happen when features is about to be applied outside the body?
Replies: 6
Views: 2292

Re: What should happen when features is about to be applied outside the body?

if you're trying to fix 2808 it wouldn't it seem better to work in the forum thread the ticket references? http://forum.freecadweb.org/viewtopic.php?f=19&t=18721 Sorry. Since it applies to other transformed features as well I thought I'd rather open new thread on this. I have one more question ...
by poserge
Sun Feb 26, 2017 4:17 am
Forum: Part Design module development
Topic: What should happen when features is about to be applied outside the body?
Replies: 6
Views: 2292

What should happen when features is about to be applied outside the body?

Hi, I'm trying to fix #2808 and I have a question on proper behavior of the PD tools such as Mirror/Linear pattern/Multitransform - what should happen if feature outside of Body is selected and PD tool applied to it? Should it should the same dialog box as if there's no active body? Or should it sho...
by poserge
Sun Feb 19, 2017 2:21 am
Forum: Install / Compile
Topic: Compiled version shows strange bug compared to release version
Replies: 3
Views: 925

Re: Compiled version shows strange bug compared to release version

Magically it started to work, even though I built and rebuilt it several times, including fresh re-build with deleted cmake cache.. I've updated to most recent commit, maybe that helped, I don't know. Anyway, I'm happy :) Thanks!
by poserge
Sat Feb 18, 2017 10:45 pm
Forum: Install / Compile
Topic: Compiled version shows strange bug compared to release version
Replies: 3
Views: 925

Compiled version shows strange bug compared to release version

Hi, I'm trying to get git version running. It compiles fine on VC2013 using FreeCADLibs_11.5.2_x64_VC12 libpack. When trying to use PartDesign feature like Pad or Revolve it crushes when I cancel the Parameter dialog. I thought it's a bug but release version works fine. I've compiled the same git co...