Low hanging fruits

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
mandeep7
Posts: 93
Joined: Wed Mar 23, 2016 10:16 am
Location: Punjab, India
Contact:

Re: Low hanging fruits

Post by mandeep7 »

ian.rees wrote:Last night, I gave a small talk on using FreeCAD at our local maker space. One of the audience pointed out that the capitalisation in the tooltips (specifically in Part Design) is inconsistent eg "Pad a.." vs "create a pocket...". I think the right way to go is capitalising the first letter, as most of the tooltips do. Perhaps finding/fixing these through FreeCAD would be a good starter project? -Ian-
I edited the Part design ones.

Also, there was extra "please" in some cases and hence seemed inconsistent.
e.g. "Please create a subtractive or additive feature first, please"

Created the pull request at: https://github.com/FreeCAD/FreeCAD/pull/131
Please review and if this is acceptable then I can look further into other workbenches to make it perfect.
ian.rees
Posts: 696
Joined: Sun Jun 15, 2014 3:28 am
Contact:

Re: Low hanging fruits

Post by ian.rees »

mandeep7 wrote:Please review and if this is acceptable then I can look further into other workbenches to make it perfect.
Your changes look good to me, thanks!

We usually make a forum post in the "Pull Requests" section at the same time as the github pull request for changes to merge to master. -Ian-
mandeep7
Posts: 93
Joined: Wed Mar 23, 2016 10:16 am
Location: Punjab, India
Contact:

Re: Low hanging fruits

Post by mandeep7 »

ian.rees wrote: Your changes look good to me, thanks!

We usually make a forum post in the "Pull Requests" section at the same time as the github pull request for changes to merge to master. -Ian-
Thanks ian,
I just added a new post there.
User avatar
NormandC
Veteran
Posts: 18589
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Low hanging fruits

Post by NormandC »

I'm wondering if this long standing feature request of mine would qualify in your list of "low hanging fruits".

issue #494 Objects names in Label & Attributes Tree View should be translatable
(Come on, say it: most of you weren't even aware of FreeCAD back then :D )

Right now, when you create a Part primitive, their labels are automatically written in the system language. To prove it, I changed FreeCAD's language settings to French, German and Spanish and went crazy with primitives:
FC_translated_labels_01.png
FC_translated_labels_01.png (29.24 KiB) Viewed 3141 times
But primitives are the only objects with translated labels. All FreeCAD objects labels should be translatable. I'm guessing this should not be so hard to code in? If it's a simple repetitive task that anyone could do once they know what to add and where, I'd even be willing to help out, in a separate branch of course.

Thanks.
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Low hanging fruits

Post by PrzemoF »

It doesn't seem to hard. I'd translate only when an object is created and leave it like that. No translatione when the language changes.
User avatar
NormandC
Veteran
Posts: 18589
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Low hanging fruits

Post by NormandC »

Agreed, forget that comment I made in the report, it's not necessary IMHO and that's how the translated primitive labels currently work, that is they are translated once at creation.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Low hanging fruits

Post by Kunda1 »

What FC objects are left to translate beside Part Primitive ?
FYI, i notated issue #494 specifically note: (http://www.freecadweb.org/tracker/view.php?id=494#c7837)
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Low hanging fruits

Post by PrzemoF »

Another easy task: add material properties from sculpteo webpage [1] to FreeCAD library.

[1] https://www.sculpteo.com/en/materials/m ... fications/
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Low hanging fruits

Post by Kunda1 »

FYI there is a tag on the bugtracker called: #lowhangingfruit to keep track of these issues
If it's OK with the devs, we could move proposed issues to the tracker
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
PrzemoF
Veteran
Posts: 3520
Joined: Fri Jul 25, 2014 4:52 pm
Contact:

Re: Low hanging fruits

Post by PrzemoF »

Thanks! I ddn't know that!
Post Reply