[FIXED] Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

[FIXED] Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Post by Kunda1 »

Forum thread for continued discussion related to issue #2354
Last edited by Kunda1 on Mon Feb 13, 2017 10:59 pm, edited 1 time in total.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
user1234
Veteran
Posts: 3490
Joined: Mon Jul 11, 2016 5:08 pm

Re: Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Post by user1234 »

Hello!

With OCC7.1 and files from 0.16 there are small errors.
0001.png
0001.png (263.21 KiB) Viewed 2696 times
But if you made a new drawing with the wonderful TechDraw workbench it works pefect.
0002.png
0002.png (228.33 KiB) Viewed 2696 times
0003.png
0003.png (204.27 KiB) Viewed 2696 times
I hope, this was helpful.

Code: Select all

OS: Debian GNU/Linux 8.6 (jessie)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.9627 (Git)
Build type: Unknown
Branch: master
Hash: e441c2a2fde8f7f8c505169c308975eb1ea0d969
Python version: 2.7.9
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 7.1.0
Greetings user1234
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Post by sgrogan »

user1234 wrote:With OCC7.1 and files from 0.16 there are small errors.
Can you highlight them?
user1234 wrote: But if you made a new drawing with the wonderful TechDraw workbench it works pefect.
user1234 wrote:OCC version: 7.1.0
Thanks!
"fight the good fight"
user1234
Veteran
Posts: 3490
Joined: Mon Jul 11, 2016 5:08 pm

Re: Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Post by user1234 »

sgrogan wrote:Can you highlight them?
If you see the first picture above, the hidden seam from the radius is visible.

Greetings user1234
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Post by Kunda1 »

user1234 wrote:
sgrogan wrote:Can you highlight them?
If you see the first picture above, the hidden seam from the radius is visible.

Greetings user1234
Sorry for my lack of education on this topic. So if the radius is visible it means this bug is no more, correct?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
NormandC
Veteran
Posts: 18589
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Post by NormandC »

I believe user1234 was talking about the edges I highlighted in yellow from his first capture.
0001_highlighted.png
0001_highlighted.png (177.05 KiB) Viewed 2632 times
These are hidden edges that should not be visible. But as I wrote in another similar bug/topic, the Drawing workbench will be deprecated in favour of TechDraw. If TechDraw no longer shows the bug, we should consider fixed.
user1234
Veteran
Posts: 3490
Joined: Mon Jul 11, 2016 5:08 pm

Re: Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Post by user1234 »

NormandC wrote:I believe user1234 was talking about the edges I highlighted in yellow from his first capture.
These are hidden edges that should not be visible. But as I wrote in another similar bug/topic, the Drawing workbench will be deprecated in favour of TechDraw. If TechDraw no longer shows the bug, we should consider fixed.
Sorry for the loooong delay and that i false worded that.

If you took a file, that was made with 0.16.XXXX, and make a drawing with 0.17.XXXXX TechDraw, it makes a false smooth visible edge (the invisble is visible).
Screenshot_0.16.XXXX.png
Screenshot_0.16.XXXX.png (205.43 KiB) Viewed 2595 times
But if you make a complete new model with 0.17.XXXXX and make a new drawing with TechDraw with that, it works perfect.
Screenshot_0.17.XXXXX.png
Screenshot_0.17.XXXXX.png (207.61 KiB) Viewed 2595 times
Actual machine:

Code: Select all

OS: Debian GNU/Linux 8.7 (jessie)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.10085 (Git)
Build type: Unknown
Branch: master
Hash: 89925e21a3a496fefd20aa47f9a974350330b0c9
Python version: 2.7.9
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 7.1.0
Solved? I am not allowed to say that. I would prefer yes. But i am not a developer.

Sorry for my bad english.

Greetings
user1234
User avatar
NormandC
Veteran
Posts: 18589
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: [FIXED] Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Post by NormandC »

user1234 wrote:If you took a file, that was made with 0.16.XXXX, and make a drawing with 0.17.XXXXX TechDraw, it makes a false smooth visible edge (the invisble is visible).
Now that's puzzling. :?

I wonder what @wandererfan makes of this?

I still haven't managed to find time to compile OCC 7.1.0 to test this myself.
triplus
Veteran
Posts: 9471
Joined: Mon Dec 12, 2011 4:45 pm

Re: [FIXED] Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Post by triplus »

Issue report was related to arcs not showing correctly and that was resolved in OCC.
user1234 wrote:But if you make a complete new model with 0.17.XXXXX and make a new drawing with TechDraw with that, it works perfect.
If this wouldn't be correct new issue related to hidden line removal would make sense. But as you say it works correctly in TechDraw in your test. Therefore no new issue needs to be reported for now. And if such issue would be detected it wouldn't be related to issue #2354.
User avatar
wandererfan
Veteran
Posts: 6310
Joined: Tue Nov 06, 2012 5:42 pm
Contact:

Re: [FIXED] Bug #2354 [Drawing] Arcs missing in projections of revolved sketches

Post by wandererfan »

NormandC wrote:I wonder what @wandererfan makes of this?
Beats me. Definitely have a hidden smooth line getting returned as a visible smooth line using the original model. I made a vaguely similar sketch using 17/7.0.1, rotated it and my hidden lines were fine.
Attachments
TechDraw Projection
TechDraw Projection
2354VisibleSmoothEdgeDrawing.png (22.08 KiB) Viewed 2526 times
Drawing Project Shape
Drawing Project Shape
VisibleSmoothEdgeProblem.png (3.73 KiB) Viewed 2526 times
Post Reply