git commit 66b91b1cdfsliptonic wrote:Has this been reverted yet? Should I create an issue to track it?
Fehler im Konturfräsen V17 ?
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
- wandererfan
- Veteran
- Posts: 6326
- Joined: Tue Nov 06, 2012 5:42 pm
- Contact:
Re: Fehler im Konturfräsen V17 ?
Re: Fehler im Konturfräsen V17 ?
That unfortunately doesn't fix the issue. I've verified in a private build that Path is still broken due to the DBL_EPSILON still being used in Vector3D.h - when I change it to FLT_EPSILON Path works correctly again.wandererfan wrote:git commit 66b91b1cdfsliptonic wrote:Has this been reverted yet? Should I create an issue to track it?
- wandererfan
- Veteran
- Posts: 6326
- Joined: Tue Nov 06, 2012 5:42 pm
- Contact:
Re: Fehler im Konturfräsen V17 ?
No, it doesn't. I had to change all my Vector3D comparisons:mlampert wrote:That unfortunately doesn't fix the issue. I've verified in a private build that Path is still broken due to the DBL_EPSILON still being used in Vector3D.h - when I change it to FLT_EPSILON Path works correctly again.
Code: Select all
- if (v3d1 == v3d2) {
+ if (v3d1.IsEqual(v3d2,tolerance)) {
Precision::Confusion() worked as tolerance for me, but you could use FLT_EPSILON instead.
wf