STEP reader improvement (Pass 2)

[vejmarie]

Just opened this PR https://github.com/FreeCAD/FreeCAD/pull/465
to fix this reported issue viewtopic.php?p=154559#p154537

[vejmarie]

Just opened this PR https://github.com/FreeCAD/FreeCAD/pull/465
to fix this reported issue viewtopic.php?p=154559#p154537

I had to cancel it. One of my reference STEP file doesn't open properly with this update unfortunatly.

[vejmarie]

I fixed the issue and reopen a new PR
https://github.com/FreeCAD/FreeCAD/pull/466

[easyw-fc]

I fixed the issue and reopen a new PR
https://github.com/FreeCAD/FreeCAD/pull/466

Great!
looking forward to test it (I need to wait for a fresh windows build, maybe also with the new multi-thread reader ...)

thx
Maurice

[easyw-fc]

I fixed the issue and reopen a new PR
https://github.com/FreeCAD/FreeCAD/pull/466

Hi @vejmarie
I managed to build it on ubuntu 16.04 and it works!
Great improvement the assembly structure is conserved (assembly & sub-assembly) ...

What I miss now are the colors...
would it be possible to add colors to the importer?

thx again for your valuable work!

Maurice

[vejmarie]

I fixed the issue and reopen a new PR
https://github.com/FreeCAD/FreeCAD/pull/466

Hi @vejmarie
I managed to build it on ubuntu 16.04 and it works!
Great improvement the assembly structure is conserved (assembly & sub-assembly) ...

What I miss now are the colors...
would it be possible to add colors to the importer?

thx again for your valuable work!

Maurice

Hi Maurice, the Colors are still there. This is because with the new PR I made, the Compound are a single Shape and I didn't transfer the color from the faces. One part of my strategy is to activate only sub elements from the Compound instead of the Compound (aka the leaf the tree instead of the nodes and roots). Assembly element have there colors. So if you disable the root nodes, and enable the leafs you will see the colors there. I like to make it first the way I describe, and if this is too disturbing for end users I will copy the color from the subelement to the Compound shapes. I like the idea to have in grey elements you can't change, and in color things which are coming from the root file.

vejmarie

[easyw-fc]

Hi Maurice, the Colors are still there. This is because with the new PR I made, the Compound are a single Shape and I didn't transfer the color from the faces. One part of my strategy is to activate only sub elements from the Compound instead of the Compound (aka the leaf the tree instead of the nodes and roots). Assembly element have there colors. So if you disable the root nodes, and enable the leafs you will see the colors there.

that is a strange behavior compared to other CAD sw ... CADAssistance or DesignSpark Mechanical just load the STEP assembly and display colors as they are; I have some feedback that Catia, SolidWorks and NT do the same... I don't know about ProE...

I like to make it first the way I describe, and if this is too disturbing for end users I will copy the color from the subelement to the Compound shapes. I like the idea to have in grey elements you can't change, and in color things which are coming from the root file.
vejmarie

If possible I would suggest to keep the colors or eventually add a check box in Pard Design settings to enable or not this feature...

what do you think?

thx
Maurice

[Jee-Bee]

I don't know about ProE...

Pro show also their colors

[vejmarie]

This will require a Pass 3 of the reader, but this shall be doable . Let's see the positive thing we are progressing.

[easyw-fc]

This will require a Pass 3 of the reader, but this shall be doable .

Great!

Let's see the positive thing we are progressing.

I'm not underestimating your contribution...
I was waiting for a STEP hierarchy parser since my first approach to FC (0.14 release I think...), and I suppose I'm not the only one!
... so I really appreciate these improvements
and there is also multi-threading in STEP reading

Thx
Maurice