[Postponed] Hole feature (C++ version)

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
Post Reply
eivindkvedalen
Posts: 602
Joined: Tue Jan 29, 2013 10:35 pm

[Postponed] Hole feature (C++ version)

Post by eivindkvedalen »

Hi,

The Hole feature mentioned in the Part Design forum is available at https://github.com/eivindkv/free-cad-code. This repository is based on the most recent git://git.code.sf.net/p/free-cad/code. The FeatureHole branch was made from the tip of jriegel/dev-assembly. It is not rebased to master yet (I've tried, but there are conflicts that I expect will resolve themselves when assembly is merged to master).

Eivind
User avatar
jriegel
Founder
Posts: 3369
Joined: Sun Feb 15, 2009 5:29 pm
Location: Ulm, Germany
Contact:

Re: Hole feature (C++ version)

Post by jriegel »

Thanks!
I will take a look!
Stop whining - start coding!
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Hole feature (C++ version)

Post by wmayer »

It seems nobody has ever looked at this. So what to do now?
User avatar
yorik
Founder
Posts: 13640
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Hole feature (C++ version)

Post by yorik »

I think it depends on the assembly branch, no? probably best to wait then...
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Hole feature (C++ version)

Post by wmayer »

As I read his post it was intended to go to master but he failed rebasing it. I also checked the assembly branch and there I can't see that it was integrated.
eivindkvedalen
Posts: 602
Joined: Tue Jan 29, 2013 10:35 pm

Re: [Postponed] Hole feature (C++ version)

Post by eivindkvedalen »

Hi all,

Is this functionality still wanted in PartDesign?

Eivind
wmayer
Founder
Posts: 20242
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: [Postponed] Hole feature (C++ version)

Post by wmayer »

No idea, I think it's best to ask ickby directly because he knows best the workbench.
ickby
Veteran
Posts: 3116
Joined: Wed Oct 05, 2011 7:36 am

Re: [Postponed] Hole feature (C++ version)

Post by ickby »

eivindkvedalen wrote:Is this functionality still wanted in PartDesign?
Yes definitely. A hole feature would be super useful. I did never look at the code of this PR, is this still working?

There was one included in PartDesign when we startet refactoring things and it is currently disabled. Personally I did test it and did not like it at all. But not sure anymore what the reason was, I only have the impression left in my head :)
eivindkvedalen
Posts: 602
Joined: Tue Jan 29, 2013 10:35 pm

Re: [Postponed] Hole feature (C++ version)

Post by eivindkvedalen »

ickby wrote:
eivindkvedalen wrote:Is this functionality still wanted in PartDesign?
Yes definitely. A hole feature would be super useful. I did never look at the code of this PR, is this still working?
I don't know. It's fairly easy to tranfer to master now, so I'll give it a try in near future then.
ickby wrote: There was one included in PartDesign when we startet refactoring things and it is currently disabled. Personally I did test it and did not like it at all. But not sure anymore what the reason was, I only have the impression left in my head :)
That one was not mine, nothing of what I did was merged.

Eivind
Post Reply