Hi,
The Hole feature mentioned in the Part Design forum is available at https://github.com/eivindkv/free-cad-code. This repository is based on the most recent git://git.code.sf.net/p/free-cad/code. The FeatureHole branch was made from the tip of jriegel/dev-assembly. It is not rebased to master yet (I've tried, but there are conflicts that I expect will resolve themselves when assembly is merged to master).
Eivind
[Postponed] Hole feature (C++ version)
-
- Posts: 602
- Joined: Tue Jan 29, 2013 10:35 pm
Re: Hole feature (C++ version)
It seems nobody has ever looked at this. So what to do now?
Re: Hole feature (C++ version)
I think it depends on the assembly branch, no? probably best to wait then...
Re: Hole feature (C++ version)
As I read his post it was intended to go to master but he failed rebasing it. I also checked the assembly branch and there I can't see that it was integrated.
-
- Posts: 602
- Joined: Tue Jan 29, 2013 10:35 pm
Re: [Postponed] Hole feature (C++ version)
Hi all,
Is this functionality still wanted in PartDesign?
Eivind
Is this functionality still wanted in PartDesign?
Eivind
Re: [Postponed] Hole feature (C++ version)
No idea, I think it's best to ask ickby directly because he knows best the workbench.
Re: [Postponed] Hole feature (C++ version)
Yes definitely. A hole feature would be super useful. I did never look at the code of this PR, is this still working?eivindkvedalen wrote:Is this functionality still wanted in PartDesign?
There was one included in PartDesign when we startet refactoring things and it is currently disabled. Personally I did test it and did not like it at all. But not sure anymore what the reason was, I only have the impression left in my head
-
- Posts: 602
- Joined: Tue Jan 29, 2013 10:35 pm
Re: [Postponed] Hole feature (C++ version)
I don't know. It's fairly easy to tranfer to master now, so I'll give it a try in near future then.ickby wrote:Yes definitely. A hole feature would be super useful. I did never look at the code of this PR, is this still working?eivindkvedalen wrote:Is this functionality still wanted in PartDesign?
That one was not mine, nothing of what I did was merged.ickby wrote: There was one included in PartDesign when we startet refactoring things and it is currently disabled. Personally I did test it and did not like it at all. But not sure anymore what the reason was, I only have the impression left in my head
Eivind