Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
helo
Posts: 3 Joined: Tue Dec 03, 2013 8:05 pm
Post
by helo » Mon Dec 30, 2013 7:17 pm
I have modified the
Airfoil importer, because it failed importing files from
xfoil or
this databse.
Therefore I changed the following
modified regular expression, now it recognizes exponential notation, e.g. 1.12312E-4
made the sorting (upper and lower side) of coordinates more flexible , the file can begin with leading or trailing edge now
I uploaded it here:
https://github.com/helo9/FreeCAD_sf_mas ... foilimport
jmaustpc
Veteran
Posts: 11207 Joined: Tue Jul 26, 2011 6:28 am
Location: Australia
Post
by jmaustpc » Tue Dec 31, 2013 2:09 am
helo wrote: I have modified the
Airfoil importer, because it failed importing files from
xfoil or
this databse.
Therefore I changed the following
modified regular expression, now it recognizes exponential notation, e.g. 1.12312E-4
made the sorting (upper and lower side) of coordinates more flexible , the file can begin with leading or trailing edge now
I uploaded it here:
https://github.com/helo9/FreeCAD_sf_mas ... foilimport
those are interesting web sites. Thanks.
the aerofoil database site pops up a window to give you an outline of the aerofoil cross section as the mouse points at one.
airfoildb.jpeg (52.84 KiB) Viewed 4351 times
yorik
Founder
Posts: 13665 Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:
Post
by yorik » Tue Dec 31, 2013 1:26 pm
Great! Your code looks good, I merged it with the master... Thanks for the improvement!
helo
Posts: 3 Joined: Tue Dec 03, 2013 8:05 pm
Post
by helo » Sat Jan 04, 2014 12:16 am
@norman: yes, but I lost the password, and recovery did not work
@yorik: nice