Test request - 1D flow

About the development of the FEM module/workbench.

Moderator: bernd

KgoaOT
Posts: 66
Joined: Mon Jul 18, 2016 9:08 am

Re: Test request - 1D flow

Post by KgoaOT »

bernd wrote:
KgoaOT wrote:Thanks Bernd.

I have just rebased on the branch and then on the latest master.

The branch can be found here: https://github.com/stoflap/FreeCAD/tree/FluidSection
Great! I found something ...
https://github.com/stoflap/FreeCAD/comm ... 9cc0f0L847

would you post your example files udated with this branch
I have just fixed the error. The branch is updated with the changes. The example file
Attachments
Resevoir.fcstd
(19.01 KiB) Downloaded 40 times
User avatar
kkremitzki
Veteran
Posts: 2511
Joined: Thu Mar 03, 2016 9:52 pm
Location: Illinois

Re: Test request - 1D flow

Post by kkremitzki »

Just compiled your branch and was messing around with the example... this is really cool! I could have used this last year as I had to hand-write the Python to basically do the same thing with a model irrigation network. I look forward to seeing where this goes.
Like my FreeCAD work? I'd appreciate any level of support via Patreon, Liberapay, or PayPal! Read more about what I do at my blog.
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Test request - 1D flow

Post by bernd »

KgoaOT wrote:
bernd wrote:
KgoaOT wrote:Thanks Bernd.

I have just rebased on the branch and then on the latest master.
I have just fixed the error. The branch is updated with the changes. The example file
Merged your code in my femdev branch for PullRequest into master. Since I did changes too I hopefully did not brake yours. Would you give it a try?

https://github.com/berndhahnebach/FreeC ... its/femdev

bernd
User avatar
makkemal
Posts: 395
Joined: Wed Apr 29, 2015 12:41 pm
Location: South Africa
Contact:

Re: Test request - 1D flow

Post by makkemal »

Ofentse yours branch looks good I have managed a few models.
I see the test file is not part of the unit tests yet ?
I think it would be a good idea to make this file even part of the examples on the front page ?
I is not that simple to under stand what it does and how it works.

@Bernd your branch requires the standard fem constraints which is not applicable to this analysis.
So it does not run
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Test request - 1D flow

Post by bernd »

makkemal wrote:Ofentse yours branch looks good I have managed a few models.
I see the test file is not part of the unit tests yet ?
I think it would be a good idea to make this file even part of the examples on the front page ?
I is not that simple to under stand what it does and how it works.
For sure it would be a good idea to make a unit test. It is so easy to break something in FEM because there is so much development going on. Taking the example on the front page is a good idea too. Take a look at git commit 108fe75 But keep in mind the examples on the front page need update on any FEM object change, means you have to stay tuned to not have an old not working example! Uptodate the unit tests write the FreeCAD file to the tmp folder means the file would be available just after a unit test run.
makkemal wrote:@Bernd your branch requires the standard fem constraints which is not applicable to this analysis.
So it does not run
could you give more informations? I just merged this code in my femdev branch, so it should be the same code? Would you (KgoaOT) fix on top of my femdev branch?

@KgoaOT: just a question:
https://github.com/berndhahnebach/FreeC ... 2e94d2R117
KgoaOT
Posts: 66
Joined: Mon Jul 18, 2016 9:08 am

Re: Test request - 1D flow

Post by KgoaOT »

makkemal wrote:Ofentse yours branch looks good I have managed a few models.
I see the test file is not part of the unit tests yet ?
I think it would be a good idea to make this file even part of the examples on the front page ?
I is not that simple to under stand what it does and how it works.
Yes I will look into making the test file part of the unit tests.

bernd wrote:For sure it would be a good idea to make a unit test. It is so easy to break something in FEM because there is so much development going on. Taking the example on the front page is a good idea too. Take a look at git commit 108fe75 But keep in mind the examples on the front page need update on any FEM object change, means you have to stay tuned to not have an old not working example! Uptodate the unit tests write the FreeCAD file to the tmp folder means the file would be available just after a unit test run.
Thanks for the example. I will also look into making the test file part of the examples on the front page.

For now I just wanted to sort the branch and get some feedback with regards to the code and if I can make any improvements.

Regards
KgoaOT
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Test request - 1D flow

Post by bernd »

rebased my femdev on master which has quite a few changes for FEM :mrgreen:

but still some minor issues, like unit test.
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Test request - 1D flow

Post by bernd »

rebased on master, no issues from my side, but 1DFlow needs to be tested. The flow example file does not work anymore. The objects needs to be recreated.

https://github.com/berndhahnebach/FreeC ... its/femdev
User avatar
bernd
Veteran
Posts: 12849
Joined: Sun Sep 08, 2013 8:07 pm
Location: Zürich, Switzerland
Contact:

Re: Test request - 1D flow

Post by bernd »

The example runs for me too. Would be cools if the 1DFlow guys could give the femdev branch a try too.
Attachments
Resevoir--bhb.fcstd
(51.91 KiB) Downloaded 36 times
KgoaOT
Posts: 66
Joined: Mon Jul 18, 2016 9:08 am

Re: Test request - 1D flow

Post by KgoaOT »

bernd wrote:rebased my femdev on master which has quite a few changes for FEM :mrgreen:

but still some minor issues, like unit test.
Haha..yes I'll get it done by next week. I'm currently swamped.
Post Reply