I have just fixed the error. The branch is updated with the changes. The example filebernd wrote:Great! I found something ...KgoaOT wrote:Thanks Bernd.
I have just rebased on the branch and then on the latest master.
The branch can be found here: https://github.com/stoflap/FreeCAD/tree/FluidSection
https://github.com/stoflap/FreeCAD/comm ... 9cc0f0L847
would you post your example files udated with this branch
Test request - 1D flow
Moderator: bernd
Forum rules
and Helpful information for the FEM forum
and Helpful information for the FEM forum
Re: Test request - 1D flow
- Attachments
-
- Resevoir.fcstd
- (19.01 KiB) Downloaded 40 times
- kkremitzki
- Veteran
- Posts: 2511
- Joined: Thu Mar 03, 2016 9:52 pm
- Location: Illinois
Re: Test request - 1D flow
Just compiled your branch and was messing around with the example... this is really cool! I could have used this last year as I had to hand-write the Python to basically do the same thing with a model irrigation network. I look forward to seeing where this goes.
Re: Test request - 1D flow
Merged your code in my femdev branch for PullRequest into master. Since I did changes too I hopefully did not brake yours. Would you give it a try?KgoaOT wrote:bernd wrote:I have just fixed the error. The branch is updated with the changes. The example fileKgoaOT wrote:Thanks Bernd.
I have just rebased on the branch and then on the latest master.
https://github.com/berndhahnebach/FreeC ... its/femdev
bernd
Re: Test request - 1D flow
Ofentse yours branch looks good I have managed a few models.
I see the test file is not part of the unit tests yet ?
I think it would be a good idea to make this file even part of the examples on the front page ?
I is not that simple to under stand what it does and how it works.
@Bernd your branch requires the standard fem constraints which is not applicable to this analysis.
So it does not run
I see the test file is not part of the unit tests yet ?
I think it would be a good idea to make this file even part of the examples on the front page ?
I is not that simple to under stand what it does and how it works.
@Bernd your branch requires the standard fem constraints which is not applicable to this analysis.
So it does not run
Re: Test request - 1D flow
For sure it would be a good idea to make a unit test. It is so easy to break something in FEM because there is so much development going on. Taking the example on the front page is a good idea too. Take a look at git commit 108fe75 But keep in mind the examples on the front page need update on any FEM object change, means you have to stay tuned to not have an old not working example! Uptodate the unit tests write the FreeCAD file to the tmp folder means the file would be available just after a unit test run.makkemal wrote:Ofentse yours branch looks good I have managed a few models.
I see the test file is not part of the unit tests yet ?
I think it would be a good idea to make this file even part of the examples on the front page ?
I is not that simple to under stand what it does and how it works.
could you give more informations? I just merged this code in my femdev branch, so it should be the same code? Would you (KgoaOT) fix on top of my femdev branch?makkemal wrote:@Bernd your branch requires the standard fem constraints which is not applicable to this analysis.
So it does not run
@KgoaOT: just a question:
https://github.com/berndhahnebach/FreeC ... 2e94d2R117
Re: Test request - 1D flow
Yes I will look into making the test file part of the unit tests.makkemal wrote:Ofentse yours branch looks good I have managed a few models.
I see the test file is not part of the unit tests yet ?
I think it would be a good idea to make this file even part of the examples on the front page ?
I is not that simple to under stand what it does and how it works.
Thanks for the example. I will also look into making the test file part of the examples on the front page.bernd wrote:For sure it would be a good idea to make a unit test. It is so easy to break something in FEM because there is so much development going on. Taking the example on the front page is a good idea too. Take a look at git commit 108fe75 But keep in mind the examples on the front page need update on any FEM object change, means you have to stay tuned to not have an old not working example! Uptodate the unit tests write the FreeCAD file to the tmp folder means the file would be available just after a unit test run.
For now I just wanted to sort the branch and get some feedback with regards to the code and if I can make any improvements.
Regards
KgoaOT
Re: Test request - 1D flow
rebased my femdev on master which has quite a few changes for FEM
but still some minor issues, like unit test.
but still some minor issues, like unit test.
Re: Test request - 1D flow
rebased on master, no issues from my side, but 1DFlow needs to be tested. The flow example file does not work anymore. The objects needs to be recreated.
https://github.com/berndhahnebach/FreeC ... its/femdev
https://github.com/berndhahnebach/FreeC ... its/femdev
Re: Test request - 1D flow
The example runs for me too. Would be cools if the 1DFlow guys could give the femdev branch a try too.
- Attachments
-
- Resevoir--bhb.fcstd
- (51.91 KiB) Downloaded 36 times
Re: Test request - 1D flow
Haha..yes I'll get it done by next week. I'm currently swamped.bernd wrote:rebased my femdev on master which has quite a few changes for FEM
but still some minor issues, like unit test.