Fixing partdesign features from being created if no active body

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Post Reply
poserge
Posts: 58
Joined: Mon Apr 06, 2015 4:06 am

Fixing partdesign features from being created if no active body

Post by poserge »

This topic started in Open discussion section and ended up with PartDesign improvements, so I'm moving it here - viewtopic.php?f=8&t=16467&p=130635#p130236

I'm not sure if this is appropriate place to post bugfixes and pullrequest, so I'll try...

Bugreport - http://freecadweb.org/tracker/view.php?id=2533
Pullrequest - https://github.com/FreeCAD/FreeCAD/pull/213
ickby wrote: Something to think about in general: It would be nice if we could think of a way to check this stuff by unit tests. Unit tests is something I also did not do very often in the past, but more and more I have the feeling to fix bugs that have worked before, but without unit test regression testing this is hard to say. But I have no idea howto check if a dialog has come up or not and howto close it programatically...
I really need to read more on testing Freecad and I probably can provide some tests.
C++ beginner, willing to help FC with coding. Using FC for converting/decomposing STEP models into iges.
Post Reply