Unused Sketcher commands?

About the development of the Part Design module/workbench. PLEASE DO NOT POST HELP REQUESTS HERE!
User avatar
kkremitzki
Posts: 314
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Unused Sketcher commands?

Postby kkremitzki » Sat Mar 11, 2017 10:02 pm

There are two commands in the toolbar which I suspect are holdouts from a previous workflow:
  • View sketch perpendicular to sketch plane
  • Close the editing of the sketch
I'm assuming they're unused, so I made a branch which removes them and adds a useful Sketcher command, to edit the selected sketch object.
https://github.com/FreeCAD/FreeCAD/comp ... 2?expand=1

Is this OK for a PR?
ian.rees
Posts: 517
Joined: Sun Jun 15, 2014 3:28 am
Contact:

Re: Unused Sketcher commands?

Postby ian.rees » Sun Mar 12, 2017 6:43 am

kkremitzki wrote:[*] View sketch perpendicular to sketch plane

I find this one quite handy - it's really easy to end up with the sketch in a funny orientation in the 3D view, this button gets it right back where it should be.

In general, I think if you're going to remove a command like this, that the code that implements it should also go away (in this case, see src/Mod/Sketcher/Gui/Command.cpp ) . Otherwise we end up with a bunch of dead code that sucks resources (mainly meaning development effort). -Ian-
ickby
Posts: 2414
Joined: Wed Oct 05, 2011 7:36 am

Re: Unused Sketcher commands?

Postby ickby » Sun Mar 12, 2017 6:58 am

Yes, good idea to remove those. They seem to have been forgotten.

@ianrees: Those command will ony be removed from PartDesign, where you cant use them anyway. When editing a sketch FreeCAD changes to the sketcher workbench where they are still available.
ian.rees
Posts: 517
Joined: Sun Jun 15, 2014 3:28 am
Contact:

Re: Unused Sketcher commands?

Postby ian.rees » Sun Mar 12, 2017 7:02 am

Ahh, got it, thanks! -Ian-