SheetMetal WB migration to 0.17

Need help, or want to share a macro? Post here!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
shaise
Posts: 470
Joined: Thu Jun 11, 2015 8:11 am

Re: SheetMetal WB migration to 0.17

Post by shaise »

DeepSOIC wrote:Warning: forced update!
I think I messed something (not that familiar with git) I made a git pull and got many conflicts.
After compilation nothing works now anymore... :? I get

Code: Select all

 "Gui::Document::slotNewObject() no view provider for the object PartDesignGui::ViewProviderPython found"
and some other errors.
will try a clean clone now. but it will take time.
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: SheetMetal WB migration to 0.17

Post by DeepSOIC »

shaise wrote:I think I messed something (not that familiar with git) I made a git pull and got many conflicts.
Actually, I'm not familiar with git pull :lol:
When I clone someone-else's branch of FreeCAD, I do something like this:

Code: Select all

git remote add DeepSOIC https://github.com/DeepSOIC/FreeCAD-ellipse.git
git fetch DeepSOIC
git checkout DeepSOIC/PartDesignPy
User avatar
shaise
Posts: 470
Joined: Thu Jun 11, 2015 8:11 am

Re: SheetMetal WB migration to 0.17

Post by shaise »

Hi DeepSOIC,

I too use that for clean cloning, I just wanted to save some time...
Anyway, I think the "bad" build actually is OK, and here is what I found so far:
When you create a Part:FeaturePython, it is assigned a default provider (to .VeiwObject), and has a 'Proxy' attr that gets the Python ViewProvider class.
If you do the same for PartDesign:FeaturePython the ViewObject is Null. Hence no proxy to set. Perhaps I should do it differently?
Clean build on the way. Just in case....

shai
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: SheetMetal WB migration to 0.17

Post by DeepSOIC »

shaise wrote:If you do the same for PartDesign:FeaturePython the ViewObject is Null. Hence no proxy to set. Perhaps I should do it differently?
No, it should work exactly the same.

Code: Select all

>>> App.ActiveDocument.addObject("PartDesign::FeaturePython")
<PartDesign::Feature>
>>> App.ActiveDocument.ActiveObject.ViewObject
<PartDesign::ViewProvider>  #<-- certainly not None/Null
>>> 
User avatar
shaise
Posts: 470
Joined: Thu Jun 11, 2015 8:11 am

Re: SheetMetal WB migration to 0.17

Post by shaise »

OK.
Waiting for clean build.
Will report when finished
User avatar
shaise
Posts: 470
Joined: Thu Jun 11, 2015 8:11 am

Re: SheetMetal WB migration to 0.17

Post by shaise »

DeepSOIC wrote:it should work exactly the same.
Yes!!!!!! :D
Everything seems to work perfectly now!
Thanks a lot for all you support.

For anyone who wants to test, please download Branch V0.17 from https://github.com/shaise/FreeCAD_SheetMetal/tree/V0.17
It should work both inside and outside PartDesign. It is also backward compatible with freecad 0.16.

As soon as the next v0.17 pre build including DeepSOIC's changes will go out, I will merge it to master.

shai
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: SheetMetal WB migration to 0.17

Post by sgrogan »

shaise wrote:As soon as the next v0.17 pre build including DeepSOIC's changes will go out, I will merge it to master.
OSX/Win builds are published: https://github.com/FreeCAD/FreeCAD/rele ... g/0.17_pre
Ubuntu is building: https://code.launchpad.net/~freecad-mai ... ners-daily
"fight the good fight"
User avatar
shaise
Posts: 470
Joined: Thu Jun 11, 2015 8:11 am

Re: SheetMetal WB migration to 0.17

Post by shaise »

Thanks sgrogan!
SheetMetal fixes merged to master.
Tested it using the Addon Manager, Works great with PartDesign WB, and follows its workflow.
V17SheetMetal.png
V17SheetMetal.png (54.47 KiB) Viewed 1603 times
User avatar
NormandC
Veteran
Posts: 18587
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: SheetMetal WB migration to 0.17

Post by NormandC »

Awesome Shai! :D

Thank you DeepSOIC for adding this functionality, and congrats Shai for being the very first module developer to use it! :)

I'm eager to test the new 0.17-compliant SheetMetal but I need to restrain myself, I've got some stuff to take care of first and it will never happen if I continue sticking around the forum... :oops:
User avatar
easyw-fc
Veteran
Posts: 3629
Joined: Thu Jul 09, 2015 9:34 am

Re: SheetMetal WB migration to 0.17

Post by easyw-fc »

shaise wrote: SheetMetal fixes merged to master.
Tested it using the Addon Manager, Works great with PartDesign WB, and follows its workflow.
Thx Shai ... this has been fixed quickly!
and Thx Sgrogan as always for your builds
Maurice
Post Reply