SheetMetal WB migration to 0.17

Need help, or want to share a macro? Post here!
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
User avatar
NormandC
Veteran
Posts: 18589
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: SheetMetal WB migration to 0.17

Post by NormandC »

Hello shaise,

I believe Serchu means a tool to create a base plate. Not requiring to either create a Part Cube or a sketch then a Pad would be useful. Basically this could be like a Part Cube, but with length, width and thickness properties.

I wonder if it would be possible to implement automatic workbench switching like Part Design does with the Sketcher? You could add Sketcher icons to your workbench. I don't know if it would be possible to do the same with Part Design tools like Pad and Pocket, which are pretty useful with your module. It would enhance the work flow by reducing the need to manually switch to other workbenches.

What do you think?

Those pesky users are never satisfied. :D
User avatar
shaise
Posts: 486
Joined: Thu Jun 11, 2015 8:11 am

Re: SheetMetal WB migration to 0.17

Post by shaise »

NormandC,

I totally agree the sketch and pad/pocket buttons should reside along with the sheetmetal workbench. I need to poke around to see if its a difficult task.

shai
User avatar
easyw-fc
Veteran
Posts: 3633
Joined: Thu Jul 09, 2015 9:34 am

Re: SheetMetal WB migration to 0.17

Post by easyw-fc »

shaise wrote: shai
Hi Shai,
I noticed that the recent version of Sheet Metal is working fine, but when creating a nested structure (i.e. bending a face and later bending an other on the same object) if the document is saved and then reloaded, the structure is flattered...
I attached an image
sheetmetal-saved-vs-created.PNG
sheetmetal-saved-vs-created.PNG (164.54 KiB) Viewed 1591 times
This issue is present both in FC0.16 and FC0.17 in win 64 and ubuntu 16.04
In previous release of Sheet metal (were there were issues for FC0.17) the structure was maintained as in the source document.

I'm attaching also the two saved examples I used for testing
bend1-saved.FCStd
(20.96 KiB) Downloaded 42 times
extend1-saved.FCStd
(8.3 KiB) Downloaded 36 times
Thx
Maurice
User avatar
shaise
Posts: 486
Joined: Thu Jun 11, 2015 8:11 am

Re: SheetMetal WB migration to 0.17

Post by shaise »

Hi Maurice,

Thanks for the observation.
Basically, when working with the new part design, the workflow should be flat - as with other part design features.
As I remember, for backward compatibility, I decided that parts made outside Part-design will be nested, but parts
inside part-design will be flat. I guess there is bug when reloading the file.
I will take a look.

shai
User avatar
shaise
Posts: 486
Joined: Thu Jun 11, 2015 8:11 am

Re: SheetMetal WB migration to 0.17

Post by shaise »

Hi Maurice,

Thanks again.
I have fixed the bug and updated on github.
It will not work on already saved files, but it will work on new ones.
Please test and let me know.

shai
User avatar
easyw-fc
Veteran
Posts: 3633
Joined: Thu Jul 09, 2015 9:34 am

Re: SheetMetal WB migration to 0.17

Post by easyw-fc »

shaise wrote: Thu Jun 22, 2017 9:49 am Hi Maurice,

Thanks again.
I have fixed the bug and updated on github.
It will not work on already saved files, but it will work on new ones.
Please test and let me know.

shai
Hi Shai,
thx for your prompt reply...
Bending now is conserving nested structure and it is fine... also unfolding is working...

I tried also Extrude on a simple cube and I get this error:

Running the Python command 'SMExtrudeFace' failed:
Traceback (most recent call last):
File "C:\Users\userC\AppData\Roaming\FreeCAD\Mod\sheetmetal\SheetMetalCmd.py", line 387, in Activated
SMViewProviderTree(a.ViewObject, False)

__init__() takes exactly 2 arguments (3 given)


Maurice
User avatar
shaise
Posts: 486
Joined: Thu Jun 11, 2015 8:11 am

Re: SheetMetal WB migration to 0.17

Post by shaise »

oops, missed that...
Please try again.
User avatar
easyw-fc
Veteran
Posts: 3633
Joined: Thu Jul 09, 2015 9:34 am

Re: SheetMetal WB migration to 0.17

Post by easyw-fc »

shaise wrote: Thu Jun 22, 2017 11:33 am oops, missed that...
Please try again.
it's fine now!
Thx a lot! :D
Maurice
User avatar
shaise
Posts: 486
Joined: Thu Jun 11, 2015 8:11 am

Re: SheetMetal WB migration to 0.17

Post by shaise »

Great! :D
triplus
Veteran
Posts: 9471
Joined: Mon Dec 12, 2011 4:45 pm

Re: SheetMetal WB migration to 0.17

Post by triplus »

Nice to see such level of support.
Post Reply