PrzemoF wrote:@Chris_G: if code works it's good, it code works and it's clean it's very good, if code works, it's clean and matches the bigger picture (FreeCAD) it's brilliant. According to my scale your code is at least good
Here are a few :PrzemoF wrote:If you know about any weak points, crashes and so on let us know
- The UI is hard-coded. I think it should go in a separate QT Designer file.
- the tool can be activated several times --> strange behaviour
- what behaviour when finishing editing, if the face is part of a solid ? create a duplicate face ? replace the edited face with the new one ?
- editing point weights ( hitting 's' while grabbing points ) would need some love ( realtime display weight value / ability to reset to 1 )
- How to react when input face is a trimmed surface ( abort ? allow editing anyway ? )
- display point coordinate in UI and allow to enter numerical values.
- add ability to select rows and columns
I agree with that comment for now. I watched all the videos of this site : http://www.aliasworkbench.com/ (very interesting) and I think there is still a long road to goPrzemoF wrote:A while age I saw a comment that FreeCAD is not designed to work with curvy surfaces. Now I look at the guitar bridge and that comment doesn't have a leg to stand on.
Chris