Acoustic guitar bridge

[Chris_G]

Hi,
Here is an acoustic guitar bridge I modelled yesterday :

Bridge-2.jpeg (19.78 KiB) Viewed 4159 times

It is the first real use of my Nurbs Surface Editor :

Bridge-1.jpeg (26.18 KiB) Viewed 4159 times

Next step is to CNC mill it.
Chris

[PrzemoF]

Looks cool! Please post the photos of the real part when you have it!

Any plans to have the NURBS surface editor in the master or it's already there?

[Jee-Bee]

Any plans to have the NURBS surface editor in the master or it's already there?

it should be handy ... at least for fixing broken step files!!

[Chris_G]

Looks cool! Please post the photos of the real part when you have it!

Hi,
I'll do it. Probably next week.

Any plans to have the NURBS surface editor in the master or it's already there?

Ahaha. No, it's not in master, and will never be. It is just crappy code :
https://github.com/tomate44/CurvesWB
Chris

[PrzemoF]

Looks cool! Please post the photos of the real part when you have it!

Hi,
I'll do it. Probably next week.

Any plans to have the NURBS surface editor in the master or it's already there?

Ahaha. No, it's not in master, and will never be. It is just crappy code :
https://github.com/tomate44/CurvesWB
Chris

Are you OK to include it in the master if someone cleans the code & commit history? It would be shame to leave a good tool as a separate code..

[r-frank]

Hello.

You can manually install this workbench.
We could ask yorik to add it to the addon-installer and sgrogran to add it to community ppa.
Then i can make an entry on the External workbenches page.

Roland

[Chris_G]

Are you OK to include it in the master if someone cleans the code & commit history? It would be shame to leave a good tool as a separate code..

Of course, I am OK. But I think my tool is probably not the good candidate for that.
The problem is that it is probably badly designed from the start ( this what I feel when trying to add little features here and there ), and I have not enough experience to design a good skeleton for it.
An experienced FC coder would certainly quickly write a better one from scratch.
This little WB is mainly for my personal entertainment and learning, also to try to sort some macros ( my macro folder is a real mess ).
But, for sure, I would love to see FC getting more Nurbs Tools.

[Chris_G]

We could ask yorik to add it to the addon-installer and sgrogran to add it to community ppa.
Then i can make an entry on the External workbenches page.

Well ... not a good idea ( unless you create a special "experimental / buggy" flag for it )
I, personally, think the addon-installer and wiki page should only reference external tools or WB of a good stable quality.
It's definitely not the case here.
Chris

[PrzemoF]

@Chris_G: if code works it's good, it code works and it's clean it's very good, if code works, it's clean and matches the bigger picture (FreeCAD) it's brilliant. According to my scale your code is at least good

If you know about any weak points, crashes and so on let us know

A while age I saw a comment that FreeCAD is not designed to work with curvy surfaces. Now I look at the guitar bridge and that comment doesn't have a leg to stand on.

[Jee-Bee]

doesn't have a leg to stand on.

What a dutch proverb that isn't that duch anymore ...