STEP reader improvement

[vejmarie]

Hi,

I just opened a PR to slightly (really slightly) improve STEP reader. The PR is creating compound into the UI as to keep track of the STEP tree structure merging multiple element from the STEP into these compounds.

vejmarie

[easyw-fc]

Hi,

I just opened a PR to slightly (really slightly) improve STEP reader. The PR is creating compound into the UI as to keep track of the STEP tree structure merging multiple element from the STEP into these compounds.

vejmarie

yeah! I was just looking forward for your coming back!

[vejmarie]

Hi,

I just opened a PR to slightly (really slightly) improve STEP reader. The PR is creating compound into the UI as to keep track of the STEP tree structure merging multiple element from the STEP into these compounds.

vejmarie

yeah! I was just looking forward for your coming back!

Yep sorry took me a lot of time, I had an unscheduled travel which came up in the US, just back home with some time during the week-end to clean what I have done as experiments. I am trying now to push upstream in a step by step

[easyw-fc]

I am trying now to push upstream in a step by step

Great!
I built it in ubuntu and it is already a nice step in the assembly structure...
Thanks so much for your effort!

Maurice

[vejmarie]

I am trying now to push upstream in a step by step

Great!
I built it in ubuntu and it is already a nice step in the assembly structure...
Thanks so much for your effort!

Maurice

You are welcome, I am currently improving the parallel code and still trying to figure out if I go for boost or tbb . Shall be pushed by the end of the week.

vejmarie

[easyw-fc]

I am trying now to push upstream in a step by step

Hi again,
I'm using the FreeCAD 'tree patch' you submitted and it works great!
I'm just tested it with some assembly with sub-assembly file that I founded here
http://www.cax-if.de/library/index.html

as1-oc-214.stp

(431.61 KiB) Downloaded 224 times

in CADAssistant I get the hierarchical structure

as1-assembly-with-sub-assembly.png (121.2 KiB) Viewed 3305 times

but in FC 9677 win64 (with the patch included) I get a plain list of items as it was before the patch...

as1-plain-structure.png (142.96 KiB) Viewed 3305 times

does the patch includes already a sub assembly hierarchy or is just a first step of this implementation?

I cannot make many test because I don't have any CAD to write STEP file a part FreeCAD and I can rely on CADAssistance or DesignSpark Mechanical to see the STEP structure...
Thx again
Maurice

[vejmarie]

Let me have a look. I tested the stuff with STEP files coming from ProE. Need probably more test case

[vejmarie]

Let me have a look. I tested the stuff with STEP files coming from ProE. Need probably more test case

I do see the same behavior than the one you see on windows. Something is probably missing somehwere. I need to check which STEP file format is it. Just give me a few days to have a look, this is a simple example.

vejmarie

[easyw-fc]

I do see the same behavior than the one you see on windows. Something is probably missing somehwere. I need to check which STEP file format is it. Just give me a few days to have a look, this is a simple example.

vejmarie

Thx again for your effort!

[vejmarie]

I do see the same behavior than the one you see on windows. Something is probably missing somehwere. I need to check which STEP file format is it. Just give me a few days to have a look, this is a simple example.

vejmarie

Thx again for your effort!

I just have opened a new PR to fix this issue https://github.com/FreeCAD/FreeCAD/pull/465. I can now open that file with the whole tree. One of the issue I see with this fix is that it is slowing down the display of Assembly as it is doubling the content. I need to check how we could improve that, but at least it works as it is supposed to.