#613 fix unpickable datum planes

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: #613 fix unpickable datum planes

Post by Kunda1 »

DeepSOIC wrote: So I hope you understand, that keeping tracker up to date is often more effort than it takes to actually fix bugs. This may explain why our tracker was so outdated it was close to useless...
Thanks for the breakdown @DeepSOIC! For the record, I wasn't complaining ;) and Yes, MantisBT has some issues but we're trying to iron them out now so that the workflow is more streamlined :) A big issue has been a lack of documentation on the part of MantisBT. That's why I researched and wrote up https://freecadweb.org/wiki/Tracker#Man ... Hub_Markup
and
https://freecadweb.org/wiki/Tracker#GitHub_and_MantisBT

Just an aside, I've been submitting bugs to both MantisBT and the Source-Integration plugin repo, for the most part they've been pretty responsive which is nice and a departure from their normal MO since before MantisBT 2.x.x
Also need to give props to @kkremitzki with his fantastic help, patience, and FTP wizardry (we don't have CLI access on the FreeCAD webhost so all changes are made via FTP :roll: )
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: #613 fix unpickable datum planes

Post by Kunda1 »

DeepSOIC wrote: 4.3 make this thread. Paste link to PR.
4.4 make link from PR to this thread
I think the devs have discussed the irrelevance of annoucing PR requests on the forum. So you might consider skipping these 2 steps to simplify your workflow.

I'm still working on the documentation for the tracker to show examples of PRs and git commits that will simplify the other steps you mentioned when interacting with Mantis via GitHub.

Also, I need to make a correction https://github.com/FreeCAD/FreeCAD/pull/622 was submitted by @jnxd not Abdullah. Apologies!
Last edited by Kunda1 on Fri Mar 17, 2017 6:08 pm, edited 1 time in total.
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
DeepSOIC
Veteran
Posts: 7896
Joined: Fri Aug 29, 2014 12:45 am
Location: used to be Saint-Petersburg, Russia

Re: #613 fix unpickable datum planes

Post by DeepSOIC »

Kunda1 wrote:I think the devs have discussed the irrelevance of annoucing PR requests on the forum. So you might consider skipping these 2 steps to simplify your workflow
OK, thanks. That makes life easier :)
Post Reply