Spreadsheet module

Merged, abandoned or rejected pull requests are moved here to clear the main Pull Requests forum.
eivindkvedalen
Posts: 602
Joined: Tue Jan 29, 2013 10:35 pm

Re: Spreadsheet module

Post by eivindkvedalen »

yorik wrote:I re-added the old python spreadsheet (in source code only, it doesn't get installed), only for archiving purposes. Maybe it would be better in TemplatePyMod actually...

I also updated the translation stuff to include the Spreadsheet module.
Good! Before some kind of generic expression support is available, the old spreadsheet actually provides some functionality that is not in the new one. If someone needs that, it's good that this is available in a transition period.

Eivind
eivindkvedalen
Posts: 602
Joined: Tue Jan 29, 2013 10:35 pm

Re: Spreadsheet module

Post by eivindkvedalen »

yorik wrote:
ulrich1a wrote:What to do with the Wiki-Page of the Python-Spreadsheet? There is a need to add some instructions for the new Spreadsheet.
Yes definitely. These need to be totally rewritten...
I'll see if I can manage to write some documentation next week. Do I need any special access to modify the wiki pages?

Eivind
jmaustpc
Veteran
Posts: 11207
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: Spreadsheet module

Post by jmaustpc »

eivindkvedalen wrote:I'll see if I can manage to write some documentation next week. Do I need any special access to modify the wiki pages?

Eivind
You have to log in to the wiki separately to the forum, I have just now had a look and you do already have the same user name set up in the wiki as your forum name. I think yours was automatically set up when we moved from Sourceforge. Let us know if you have any problems.

Jim
ulrich1a
Veteran
Posts: 1957
Joined: Sun Jul 07, 2013 12:08 pm

Re: Spreadsheet module

Post by ulrich1a »

yorik wrote: ulrich1a wrote:What to do with the Wiki-Page of the Python-Spreadsheet? There is a need to add some instructions for the new Spreadsheet.


Yes definitely. These need to be totally rewritten...
I was asking also what should be happen with the old Spreadsheet page. Do we need for a certain time both pages? Yorik could you give the old Spreadsheet page just a different name? Or how would the transition period handled in the wiki?

If we agree, on how to organize the transition, we can already start to make a page for the new Spreadsheet.

Ulrich
eivindkvedalen
Posts: 602
Joined: Tue Jan 29, 2013 10:35 pm

Re: Spreadsheet module

Post by eivindkvedalen »

Some bugfixes that can be cherry-picked from SpreadsheetMod2. Except the alias issue reported by ickby (which I think isn't a problem in the spreadsheet module, it just exposes it), I think the commits below fixes all reported problems so far.

(viewtopic.php?f=10&t=9737#p78991)
https://github.com/eivindkv/free-cad-co ... 5577e8ca6e
Fixed crash when setting/resetting bold/italic/underline on empty cells.

(viewtopic.php?f=10&t=9737#p78991
viewtopic.php?f=10&t=9737#p79036)
https://github.com/eivindkv/free-cad-co ... 0c645e2b97
Consistently use App::Document::Label as reference for document names when tracking dependencies.

Not able to test with different language, but tested with relabeling when files are saved first time, and then saved as, and loaded.

(viewtopic.php?f=10&t=9737&start=10#p79093)
https://github.com/eivindkv/free-cad-co ... 38761903f0
Don't return error message when custom attribute is not found.

(viewtopic.php?f=10&t=9737&start=10#p79043)
https://github.com/eivindkv/free-cad-co ... 084de8a5a9
docDeps property was not properly maintained, resulting in spurious links to other objects.

https://github.com/eivindkv/free-cad-co ... c0a1ef2147
Minor clean-up.

https://github.com/eivindkv/free-cad-co ... 137d88fd6c
(a fix for previous commit c8c007baba2045a9c9e5a8fddfc000084de8a5a9)

Eivind
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Spreadsheet module

Post by wmayer »

All cherry-picked.
eivindkvedalen
Posts: 602
Joined: Tue Jan 29, 2013 10:35 pm

Re: Spreadsheet module

Post by eivindkvedalen »

Hi,

Various updates to the Spreadsheet module:

From
https://github.com/eivindkv/free-cad-co ... 137d88fd6c

To:
https://github.com/eivindkv/free-cad-co ... d7f0088bba

(everything from last cherry-pick)

There are a lot of commits that in sum fixes:
- Self-reference bug
- Refactoring/clean-up of code
- Dependency tracking of aliased cells
- Various resolution errors
- Rewriting of ranges when columns/rows are inserted/removed
- References to aliases keep their units.

Only source files in the Spreadsheet directory are changed. Most commits have been available for some time on github for testing, and I've received positive feedback from Ulrich on bug reports from him.

Thanks,
Eivind
wmayer
Founder
Posts: 20243
Joined: Thu Feb 19, 2009 10:32 am
Contact:

Re: Spreadsheet module

Post by wmayer »

git cherry-picked and squashed using your summary as commit message.
Post Reply