Mistake with Addon Manager

Post here for help on using FreeCAD's graphical user interface (GUI).
Forum rules
and Helpful information
IMPORTANT: Please click here and read this first, before asking for help

Also, be nice to others! Read the FreeCAD code of conduct!
renatorivo
Veteran
Posts: 2611
Joined: Tue Feb 21, 2012 8:07 pm
Location: Torino - Italy

Mistake with Addon Manager

Post by renatorivo »

Sorry if maybe it's already been reported, but I have an error with Addon manager (xx% traduit)
addon.png
addon.png (5.34 KiB) Viewed 2319 times
If I click on one of these items I get this message

Code: Select all

Traceback (most recent call last):
  File "C:\Users\User\Downloads\FreeCAD_0.17.10530_x64_dev_win\Mod\AddonManager\AddonManager.py", line 433, in run
    u = urllib2.urlopen(url)
  File "C:\Users\User\Downloads\FreeCAD_0.17.10530_x64_dev_win\bin\lib\urllib2.py", line 127, in urlopen
    return _opener.open(url, data, timeout)
  File "C:\Users\User\Downloads\FreeCAD_0.17.10530_x64_dev_win\bin\lib\urllib2.py", line 410, in open
    response = meth(req, response)
  File "C:\Users\User\Downloads\FreeCAD_0.17.10530_x64_dev_win\bin\lib\urllib2.py", line 523, in http_response
    'http', request, response, code, msg, hdrs)
  File "C:\Users\User\Downloads\FreeCAD_0.17.10530_x64_dev_win\bin\lib\urllib2.py", line 448, in error
    return self._call_chain(*args)
  File "C:\Users\User\Downloads\FreeCAD_0.17.10530_x64_dev_win\bin\lib\urllib2.py", line 382, in _call_chain
    result = func(*args)
  File "C:\Users\User\Downloads\FreeCAD_0.17.10530_x64_dev_win\bin\lib\urllib2.py", line 531, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)
urllib2.HTTPError: HTTP Error 400: Bad Request
OS: Windows 8.1
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.10530 (Git)
Build type: Release
Branch: master
Hash: d920cf419d9ed8274d10597364d92f224ded7b4f
Python version: 2.7.8
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.0.0

Same with Ubuntu 16.04.2 LTS + FreeCAD daily


Renato
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Mistake with Addon Manager

Post by sgrogan »

Same here. These don't look like macros.
OS: Ubuntu 14.04.5 LTS
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.10600 (Git)
Build type: None
Branch: master
Hash: 4d9169faf778e9716fc647fb3fcf46462b5d99a4
Python version: 2.7.6
Qt version: 4.8.6
Coin version: 4.0.0a
OCC version: 7.1.0
"fight the good fight"
User avatar
NormandC
Veteran
Posts: 18589
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Mistake with Addon Manager

Post by NormandC »

FC017_Addon_manager_01.png
FC017_Addon_manager_01.png (38.52 KiB) Viewed 2294 times
The AddonManager.py script extracts the list of macros directly from the wiki. Nifty idea! But obviously it extracts pages starting with "Macro", and thus tries to download from the Macros recipes page.

I think it needs to be added to the MACROS_BLACKLIST parameter:

https://github.com/FreeCAD/FreeCAD/blob ... ger.py#L45

Code: Select all

MACROS_BLACKLIST = ["BOLTS","WorkFeatures","how to install","PartsLibrary"]
I'm just not sure if it should be added as "recipes" or "s recipes".

For the curious, "traduit" is French for "translated". The fact it's shown in French is another mystery :D
User avatar
yorik
Founder
Posts: 13659
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Mistake with Addon Manager

Post by yorik »

Aha, that's the "languages" box at the bottom of the page. How strange that this error never happened before! Fixed in git commit 7667875e0
User avatar
yorik
Founder
Posts: 13659
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Mistake with Addon Manager

Post by yorik »

One of these days, we should add a little system that checks and notifies which workbenches have an available update...
User avatar
saso
Veteran
Posts: 1924
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Mistake with Addon Manager

Post by saso »

yorik wrote:One of these days, we should add a little system that checks and notifies which workbenches have an available update...
+1 :)
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Mistake with Addon Manager

Post by Kunda1 »

yorik wrote:One of these days, we should add a little system that checks and notifies which workbenches have an available update...
Where should this feature be filed? The addon manager github issue tracker or mantis ?
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
User avatar
sgrogan
Veteran
Posts: 6499
Joined: Wed Oct 22, 2014 5:02 pm

Re: Mistake with Addon Manager

Post by sgrogan »

Kunda1 wrote:Where should this feature be filed? The addon manager github issue tracker or mantis ?
Mantis, the macro on github is for legacy support. The functionality has been integrated into FreeCAD's Tools menu.
"fight the good fight"
User avatar
yorik
Founder
Posts: 13659
Joined: Tue Feb 17, 2009 9:16 pm
Location: Brussels
Contact:

Re: Mistake with Addon Manager

Post by yorik »

Yes, the macro won't be developed further, normally...
User avatar
Kunda1
Veteran
Posts: 13434
Joined: Thu Jan 05, 2017 9:03 pm

Re: Mistake with Addon Manager

Post by Kunda1 »

Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Post Reply