Soft UI/UX suggestions for Macro Addon Installer

A subforum for research and development of the user interface of FreeCAD

Moderator: agryson

User avatar
agryson
Posts: 438
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby agryson » Tue Jan 24, 2017 7:29 am

kkremitzki wrote:The 2/3rds, 1/3rds split looked a little extreme. I went with half and half for this redesign:
OK, looking great, in any case once we're loading real data we'll have a better idea.

Does that loader bar change color based on the theme automatically (dark/green, dark/blue etc.)
User avatar
agryson
Posts: 438
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby agryson » Tue Jan 24, 2017 7:30 am

Just noticed the filter... excellent!
User avatar
kkremitzki
Posts: 318
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby kkremitzki » Tue Jan 24, 2017 7:39 am

agryson wrote:
kkremitzki wrote:Does that loader bar change color based on the theme automatically (dark/green, dark/blue etc.)

Hard to say--right now it's essentially little more than a mockup element. I think in the addon currently the "progress" bar (it really is just an activity one since it goes back and forth) matches my theme. So, I presume there will be some level of support for such behavior in this object or another.
User avatar
agryson
Posts: 438
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby agryson » Tue Jan 24, 2017 9:04 am

kkremitzki wrote:I presume there will be some level of support for such behavior in this object or another.
Yeah, I'm pretty sure it's baked in, but something to add to the checklist before upstreaming.

If it's just a spinner type bar, is there a way to remove the percentage value and maybe drop its visual weight by making it about 3 to 5 px high? (I'll be installing QT designer this week at home and can try myself if you don't have the time)
User avatar
Kunda1
Posts: 619
Joined: Thu Jan 05, 2017 9:03 pm

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby Kunda1 » Tue Jan 24, 2017 2:57 pm

kkremitzki wrote:The 2/3rds, 1/3rds split looked a little extreme. I went with half and half for this redesign:


Nice!!!
User avatar
agryson
Posts: 438
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby agryson » Tue Jan 24, 2017 3:30 pm

kkremitzki wrote:I just threw together a basic AddonManager.ui file based on the Execute Macro window.
I'm not seeing this on your branch, I see some widget talking about degrees or something. Is that work still local?

Edit: typos
User avatar
kkremitzki
Posts: 318
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby kkremitzki » Tue Jan 24, 2017 10:27 pm

agryson wrote:
kkremitzki wrote:I just threw together a basic AddonManager.ui file based on the Execute Macro window.
I'm not seeing this on your branch, I see some widget talking about degrees or something. Is that work still local?

Edit: typos

Yep, I only made the .ui file and spent the rest of the night reading up on Qt, especially the "signals and slots" mechanism they use to avoid the callback hell I'm more familiar with in the web app world. I'll post again when I have more progress on actually implementing that .ui file.
User avatar
kkremitzki
Posts: 318
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby kkremitzki » Wed Feb 01, 2017 10:21 am

I re-did my implementation of the "add an item to the Tools menu" code to be a bit cleaner by adding an AddonManager module:
https://github.com/FreeCAD/FreeCAD/comp ... zki:addon2

I think this might be ready for upstreaming just to get some code out to people; it's a straightforward port of the Addons_installer macro to the UI. What do y'all think?
User avatar
sgrogan
Posts: 2978
Joined: Wed Oct 22, 2014 5:02 pm

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby sgrogan » Wed Feb 01, 2017 7:22 pm

kkremitzki wrote:What do y'all think?

I get a build failure trying to copy a non-existent file from this
https://github.com/kkremitzki/FreeCAD/blob/f0aecd3adf842013ec18e9deb974041e10bbdd33/src/Mod/AddonManager/CMakeLists.txt#L16-L21
It can be deleted as you are not using a resource file.
Otherwise it seems to work well.
User avatar
yorik
Site Admin
Posts: 8549
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby yorik » Wed Feb 01, 2017 9:31 pm

You placed the addon manager in an module folder, I had thought of simply adding it to src/Gui, but thinking better, then where would it be installed... So yeah your approach seems right. I didn't test yet, but looks OK to me