Soft UI/UX suggestions for Macro Addon Installer

A subforum for research and development of the user interface of FreeCAD

Moderator: agryson

User avatar
kkremitzki
Posts: 318
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby kkremitzki » Wed Feb 01, 2017 9:40 pm

sgrogan wrote:
kkremitzki wrote:What do y'all think?

I get a build failure trying to copy a non-existent file from this
https://github.com/kkremitzki/FreeCAD/blob/f0aecd3adf842013ec18e9deb974041e10bbdd33/src/Mod/AddonManager/CMakeLists.txt#L16-L21
It can be deleted as you are not using a resource file.
Otherwise it seems to work well.

Ah, thanks, that was a relic of an earlier stage of development. I had tried to put the icon in src/Mod/AddonManager/Resources/icons but no matter what I tweaked, I'd get an icon not found error. I would have preferred to keep the icon there but ended up having to put it in src/Gui/Icons. I pushed a fix to the branch.

I figured it was an issue of the module code not having loaded and declared the resource at the time the GUI was coming up.
User avatar
sgrogan
Posts: 2978
Joined: Wed Oct 22, 2014 5:02 pm

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby sgrogan » Wed Feb 01, 2017 10:01 pm

kkremitzki wrote:Ah, thanks, that was a relic of an earlier stage of development. I had tried to put the icon in src/Mod/AddonManager/Resources/icons but no matter what I tweaked, I'd get an icon not found error. I would have preferred to keep the icon there but ended up having to put it in src/Gui/Icons. I pushed a fix to the branch.

I figured it was an issue of the module code not having loaded and declared the resource at the time the GUI was coming up.

I'm not a cmake guru but I think the whole block I highlighted in my previous post can be deleted. After your last change I think your copying nothing from one place to another? Compiling now to check.
User avatar
kkremitzki
Posts: 318
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby kkremitzki » Wed Feb 01, 2017 10:17 pm

sgrogan wrote:
kkremitzki wrote:Ah, thanks, that was a relic of an earlier stage of development. I had tried to put the icon in src/Mod/AddonManager/Resources/icons but no matter what I tweaked, I'd get an icon not found error. I would have preferred to keep the icon there but ended up having to put it in src/Gui/Icons. I pushed a fix to the branch.

I figured it was an issue of the module code not having loaded and declared the resource at the time the GUI was coming up.

I'm not a cmake guru but I think the whole block I highlighted in my previous post can be deleted. After your last change I think your copying nothing from one place to another? Compiling now to check.


Testing here as well, I figured that change was the minimum to not have a failed build, but I'm even less than "not a cmake guru" myself.

Edit: Just finished compiling and it looks good, I removed that whole block and pushed the changes again.
User avatar
sgrogan
Posts: 2978
Joined: Wed Oct 22, 2014 5:02 pm

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby sgrogan » Wed Feb 01, 2017 10:27 pm

kkremitzki wrote:Testing here as well, I figured that change was the minimum to not have a failed build, but I'm even less than "not a cmake guru" myself.

Edit: Just finished compiling and it looks good, I removed that whole block and pushed the changes again.

I did the same locally, everything is good, all unit tests passed from the gui. I vote for a pull request.
User avatar
sgrogan
Posts: 2978
Joined: Wed Oct 22, 2014 5:02 pm

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby sgrogan » Thu Feb 02, 2017 11:15 pm

You guys should make a feature announcement. @yorik I just noticed the dxf stuff, great! I think this should greatly help the users! No more trouble getting the addon macro as raw etc. Congrats!
User avatar
sgrogan
Posts: 2978
Joined: Wed Oct 22, 2014 5:02 pm

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby sgrogan » Thu Feb 02, 2017 11:30 pm

sgrogan wrote:@yorik I just noticed the dxf stuff, great!

Can the macro be adjusted to look for previously installed version in the macro folder and delete at install as a module?
User avatar
kkremitzki
Posts: 318
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby kkremitzki » Fri Feb 03, 2017 8:25 am

sgrogan wrote:
sgrogan wrote:@yorik I just noticed the dxf stuff, great!

Can the macro be adjusted to look for previously installed version in the macro folder and delete at install as a module?

Can you elaborate? I'm having a hell of a time parsing this post.
User avatar
yorik
Site Admin
Posts: 8549
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby yorik » Fri Feb 03, 2017 12:39 pm

sgrogan wrote:Can the macro be adjusted to look for previously installed version in the macro folder and delete at install as a module?

Updating a macro should just delete the old files, normally...
User avatar
sgrogan
Posts: 2978
Joined: Wed Oct 22, 2014 5:02 pm

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby sgrogan » Fri Feb 03, 2017 12:45 pm

yorik wrote:Updating a macro should just delete the old files, normally...

I mean if a user has "Allow FreeCAD to automatically download and update DXF libraries" in Import/Export DXF prefs and installs with the Addons installer, then there are two copies. One in the Mod folder and one in the Macros folder.
User avatar
NormandC
Posts: 12042
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Soft UI/UX suggestions for Macro Addon Installer

Postby NormandC » Sat Feb 04, 2017 7:42 am

I hadn't followed on your progress until I saw this was merged. Great work guys! :)

It even recognized workbenches I installed manually by Git.

Just wondering, was the UI redesign with preview pane by kkremitzki abandoned? My Addon manager window still looks like the one from the first post in this topic.