Part Design Workbench icons aligned to guidelines

A subforum for research and development of the user interface of FreeCAD

Moderator: agryson

User avatar
agryson
Posts: 444
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Part Design Workbench icons aligned to guidelines

Postby agryson » Sun Feb 19, 2017 2:02 pm

Sorry about the delay on these, I totally borked my system last weekend and had to divert hobby time to recovering everything.

As usual, old on left, new on right on light, gray and dark backgrounds at 16,24,32 64px.
spritesheet_A.png
spritesheet_A.png (508.43 KiB) Viewed 380 times
spritesheet_B.png
spritesheet_B.png (540.97 KiB) Viewed 380 times


Comments and feedback welcome.
triplus
Posts: 4866
Joined: Mon Dec 12, 2011 4:45 pm

Re: Part Design Workbench icons aligned to guidelines

Postby triplus » Sun Feb 19, 2017 2:03 pm

Looking good and thanks for doing it.
User avatar
agryson
Posts: 444
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Part Design Workbench icons aligned to guidelines

Postby agryson » Sun Feb 19, 2017 10:33 pm

triplus wrote:Looking good and thanks for doing it.
No worries, thank you. Not many left to go now!
User avatar
NormandC
Posts: 12080
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Part Design Workbench icons aligned to guidelines

Postby NormandC » Sun Feb 19, 2017 11:49 pm

Great!

But sorry to be nitpicking, the perspective in a few icons is way off. Granted on at least one of them it was bad to begin with.

I doubled the following's resolution to better display what I mean.

PartDesign_Hole.svg
FC017_PD_Hole.png
FC017_PD_Hole.png (57.85 KiB) Viewed 337 times

Green oval at far right represents mostly correct shape. basically the ellipse shape's main axis should be horizontal.

See this screenshot I found in my Images folder. This is an isometric view.
FC_aricbeaver_view_01.png
FC_aricbeaver_view_01.png (16.92 KiB) Viewed 334 times


BTW this icon is still not visible in the PartDesign toolbar, it's for the Hole feature. There's code by eivindkvedalen for it in a separate branch, I hope it gets merged soon.

PartDesign_LinearPattern.svg

FC017_PD_LinPattern_01.png
FC017_PD_LinPattern_01.png (64.14 KiB) Viewed 337 times

If a sense of perspective was intended, the point where the green projection lines meet should be on the left side rather than the right side.

The same problem can be seen on the Mirrored and PolarPattern icons.

Overall I think they look much better! I like the new InvoluteGear.
User avatar
agryson
Posts: 444
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Part Design Workbench icons aligned to guidelines

Postby agryson » Mon Feb 20, 2017 6:54 am

NormandC wrote:basically the ellipse shape's main axis should be horizontal.
True, I have to admit I was trying to make the ellipse as big as possible rather than as accurate as possible. As a true round hole, the icon appears very similar to the pocket icon at smaller/normal sizes. I'll have another crack at it, but knowing it's a 0.17 icon, I might even put the hole in the front face rather than the top face to make it more distinguishable. Thanks for the feedback!

NormandC wrote:If a sense of perspective was intended, the point where the green projection lines meet should be on the left side rather than the right side.
My focus here was on dropping that front line to give me more space for the small cubes - I agree it's messed up the perspective. I'll straighten up the rear line to make it more parallel to reduce the effect. Thanks for the spot.

Also thanks for taking the time to make the visuals, it really gets across the feedback very clearly and I know it can sometimes take a bit of time. Much appreciated.
User avatar
agryson
Posts: 444
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Part Design Workbench icons aligned to guidelines

Postby agryson » Mon Feb 20, 2017 8:34 pm

NormandC wrote:But sorry to be nitpicking, the perspective in a few icons is way off.
Here's the new icons with the updated perspective. (I only show one of the pattern ones, but it's the same perspective change on all of them).

I've now made the hole in the square before transfroming.

spritesheet.png
spritesheet.png (32.71 KiB) Viewed 276 times


Unless there's any other feedback, I hope to submit a pull request tomorrow sometime. Robot workbench is almost done and should be ready for this weekend.
User avatar
NormandC
Posts: 12080
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Part Design Workbench icons aligned to guidelines

Postby NormandC » Tue Feb 21, 2017 2:06 am

Cool!

Looks fine to me! :)

I'm getting used to the realigned icons so much that when in 0.16, I find the old icons weird :D
User avatar
agryson
Posts: 444
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Part Design Workbench icons aligned to guidelines

Postby agryson » Tue Feb 21, 2017 6:07 am

NormandC wrote:Looks fine to me! :)
Great!

NormandC wrote:I'm getting used to the realigned icons so much that when in 0.16, I find the old icons weird :D
Cool, out of interest though, despite weirdness, you can still orient yourself ok, right? I've been trying to make sure the new icons are still recognizable for people used to the old ones.
User avatar
agryson
Posts: 444
Joined: Wed Nov 23, 2016 8:30 am
Location: Paris, France
Contact:

Re: Part Design Workbench icons aligned to guidelines

Postby agryson » Tue Feb 21, 2017 9:48 am

User avatar
NormandC
Posts: 12080
Joined: Sat Feb 06, 2010 9:52 pm
Location: Québec, Canada

Re: Part Design Workbench icons aligned to guidelines

Postby NormandC » Wed Feb 22, 2017 3:38 am

agryson wrote:Cool, out of interest though, despite weirdness, you can still orient yourself ok, right?

Of course! I just meant that they look, well maybe "old fashioned". Even though I did design half a dozen of them :D