Assembly Workbench icons aligned to guidelines
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Assembly Workbench icons aligned to guidelines
Last real workbench, just the core icons left!
Old on left, new on right, on light, mid-grey and dark backgrounds at 16, 24, 32 and 64px respectively.
Question: anyone know where the main workbench icon for assembly is? I can't find it in the usual Gui/Resources/icons
Feedback welcome.
Old on left, new on right, on light, mid-grey and dark backgrounds at 16, 24, 32 and 64px respectively.
Question: anyone know where the main workbench icon for assembly is? I can't find it in the usual Gui/Resources/icons
Feedback welcome.
Re: Assembly Workbench icons aligned to guidelines
You are moving mountains Alex! But I guess that's the way things go with FreeCAD
- DeepSOIC
- Veteran
- Posts: 7896
- Joined: Fri Aug 29, 2014 12:45 am
- Location: used to be Saint-Petersburg, Russia
Re: Assembly Workbench icons aligned to guidelines
It is hard-coded into InitGui.py as XPM string.agryson wrote:Question: anyone know where the main workbench icon for assembly is? I can't find it in the usual Gui/Resources/icons
Re: Assembly Workbench icons aligned to guidelines
Thanks, I imagine that's just during dev, a main icon will eventually be required (to show up in settings etc.), no?DeepSOIC wrote:It is hard-coded into InitGui.py as XPM string.
- DeepSOIC
- Veteran
- Posts: 7896
- Joined: Fri Aug 29, 2014 12:45 am
- Location: used to be Saint-Petersburg, Russia
Re: Assembly Workbench icons aligned to guidelines
Yep! Would be great if you make one.agryson wrote:, a main icon will eventually be required (to show up in settings etc.), no?
Re: Assembly Workbench icons aligned to guidelines
I don't know why i left out Assembly workbench when i did the conversion from XPM to SVG workbench icons. Likely one of the following reasons:
- It's disabled by default and not usable.
- It wasn't in compilable state and i couldn't easily test the changes.
- Or both.
Re: Assembly Workbench icons aligned to guidelines
Well it's at the top of InitGui, I could easily whip something up since it seems very similar to the tree icons that I've already done, just need the page at top right. I'll try to have that done today or tomorrow to make it part of the pull request. If I have difficulties, I might ping you @triplustriplus wrote:I don't know why i left out Assembly workbench when i did the conversion from XPM to SVG workbench icons. Likely one of the following reasons:
P.S. If there is desire i can still do that in the following week.
- It's disabled by default and not usable.
- It wasn't in compilable state and i couldn't easily test the changes.
- Or both.
Re: Assembly Workbench icons aligned to guidelines
You can look for reference here:
https://github.com/FreeCAD/FreeCAD/pull/102
You'll need to edit InitGui.py and CMakeLists.txt file. Adding the icon to resources (.qrc) isn't technically needed for workbench icon purposes ATM. But i guess it doesn’t hurt to have the icon available from the resources.
https://github.com/FreeCAD/FreeCAD/pull/102
You'll need to edit InitGui.py and CMakeLists.txt file. Adding the icon to resources (.qrc) isn't technically needed for workbench icon purposes ATM. But i guess it doesn’t hurt to have the icon available from the resources.
Re: Assembly Workbench icons aligned to guidelines
Thanks for the heads up, my build was complaining of a missing icon - I had edited InitGui.py but had missed the CMakeLists.txt.triplus wrote:You'll need to edit InitGui.py and CMakeLists.txt file.
I should be able to post something in the next hour or so.
Re: Assembly Workbench icons aligned to guidelines
Done.
Thanks for the tip on implementation @triplus
This can now be in the pull request. (tested sucessfully on local)
Thanks for the tip on implementation @triplus
This can now be in the pull request. (tested sucessfully on local)