Freecad 0.16 source.tar.gz out of date?

[NormandC]

Correct! Everything is autogenerated by github. I created a new release on github, tagged at the HEAD of the 0-16 release branch. I copied the aurogenerated .zip and .tar.bz files to the existing release and deleted the new release.

I didn't know it was automatically built. This may cause trouble for packaging, like on Fedora the package shows "$WCREV$" instead of the revision number... I guess they may have no choice but create the Version.h file from scratch...

[sgrogan]

I didn't know it was automatically built. This may cause trouble for packaging, like on Fedora the package shows "$WCREV$" instead of the revision number... I guess they may have no choice but create the Version.h file from scratch...

Exactly, this is why we need the versioning branch for the PPA. It's not easy though. A commit to bump the version of the commit is not a solution
I think other build systems could use a similar method. From my point of view this is a good problem. FreeCAD is cross-platform, these problems are identified as the use spreads.

[fafc]

Hmm, I can't quite follow...

However package was build using https://github.com/FreeCAD/FreeCAD/rele ... 706.tar.gz and it still reports 0.16.5235...

So yeah in the end, I probably was already using the latest version...

Also during compile:

Code: Select all

error fatal: Invalid revision range 6b3d7b17a749e03bcbf2cf79bbbb903137298c44..HEAD

howeveer build was fine.

[ugjka]

Hi, I'm the aformentioned packager for Chakra linux.

It seems that revision number is determined from git repo state, atleast I found a script in sources that does that. If it can't find a valid git repo then it defaults to 5235 for some unknown reason. Since tarballs do not contain any .git repo then obviously all build from them have incorrect revision number

So I had to use the git branch directly in my PKGBUILD using makepkg VCS capabilities. And now revision number shows up correctly.

Thanks, hope this sheds some light!

[sgrogan]

Hi, I'm the aformentioned packager for Chakra linux.

Hello ugjka and Welcome! Thanks for supporting FreeCAD on your OS
Building with git is the best way to go. I thought, obviously wrongly, that if the versioning script failed, then the version would be unknown or "$WCREV$" as NormandC mentioned. The fact that it happily reports the wrong version is troubling.

[ugjka]

Thanks!

Here's a snippet from src/Tools/SubWCRev.py that shows where it gets 5235

Code: Select all

   def revisionNumber(self, srcdir,origin=None):
        """sets the revision number
for master and release branches all commits are counted
for other branches the version numver is split in two parts
the first number reflects the number of commits in common with the
blessed master repository.
the second part, seperated by " +"reflects the number of commits that are
different form the master repository"""
        #referencecommit="f119e740c87918b103140b66b2316ae96f136b0e"
        #referencerevision=4138
        referencecommit="6b3d7b17a749e03bcbf2cf79bbbb903137298c44"
        referencerevision=5235

[Kunda1]

Linking related post: viewtopic.php?f=4&t=19903