I didn't know it was automatically built. This may cause trouble for packaging, like on Fedora the package shows "$WCREV$" instead of the revision number... I guess they may have no choice but create the Version.h file from scratch...sgrogan wrote:Correct! Everything is autogenerated by github. I created a new release on github, tagged at the HEAD of the 0-16 release branch. I copied the aurogenerated .zip and .tar.bz files to the existing release and deleted the new release.
Freecad 0.16 source.tar.gz out of date?
Forum rules
Be nice to others! Respect the FreeCAD code of conduct!
Be nice to others! Respect the FreeCAD code of conduct!
Re: Freecad 0.16 source.tar.gz out of date?
Re: Freecad 0.16 source.tar.gz out of date?
Exactly, this is why we need the versioning branch for the PPA. It's not easy though. A commit to bump the version of the commit is not a solutionNormandC wrote:I didn't know it was automatically built. This may cause trouble for packaging, like on Fedora the package shows "$WCREV$" instead of the revision number... I guess they may have no choice but create the Version.h file from scratch...
I think other build systems could use a similar method. From my point of view this is a good problem. FreeCAD is cross-platform, these problems are identified as the use spreads.
"fight the good fight"
Re: Freecad 0.16 source.tar.gz out of date?
Hmm, I can't quite follow...
However package was build using https://github.com/FreeCAD/FreeCAD/rele ... 706.tar.gz and it still reports 0.16.5235...
So yeah in the end, I probably was already using the latest version...
Also during compile:
howeveer build was fine.
However package was build using https://github.com/FreeCAD/FreeCAD/rele ... 706.tar.gz and it still reports 0.16.5235...
So yeah in the end, I probably was already using the latest version...
Also during compile:
Code: Select all
error fatal: Invalid revision range 6b3d7b17a749e03bcbf2cf79bbbb903137298c44..HEAD
Re: Freecad 0.16 source.tar.gz out of date?
Hi, I'm the aformentioned packager for Chakra linux.
It seems that revision number is determined from git repo state, atleast I found a script in sources that does that. If it can't find a valid git repo then it defaults to 5235 for some unknown reason. Since tarballs do not contain any .git repo then obviously all build from them have incorrect revision number
So I had to use the git branch directly in my PKGBUILD using makepkg VCS capabilities. And now revision number shows up correctly.
Thanks, hope this sheds some light!
It seems that revision number is determined from git repo state, atleast I found a script in sources that does that. If it can't find a valid git repo then it defaults to 5235 for some unknown reason. Since tarballs do not contain any .git repo then obviously all build from them have incorrect revision number
So I had to use the git branch directly in my PKGBUILD using makepkg VCS capabilities. And now revision number shows up correctly.
Thanks, hope this sheds some light!
Re: Freecad 0.16 source.tar.gz out of date?
Hello ugjka and Welcome! Thanks for supporting FreeCAD on your OSugjka wrote:Hi, I'm the aformentioned packager for Chakra linux.
Building with git is the best way to go. I thought, obviously wrongly, that if the versioning script failed, then the version would be unknown or "$WCREV$" as NormandC mentioned. The fact that it happily reports the wrong version is troubling.
"fight the good fight"
Re: Freecad 0.16 source.tar.gz out of date?
Thanks!
Here's a snippet from src/Tools/SubWCRev.py that shows where it gets 5235
Here's a snippet from src/Tools/SubWCRev.py that shows where it gets 5235
Code: Select all
def revisionNumber(self, srcdir,origin=None):
"""sets the revision number
for master and release branches all commits are counted
for other branches the version numver is split in two parts
the first number reflects the number of commits in common with the
blessed master repository.
the second part, seperated by " +"reflects the number of commits that are
different form the master repository"""
#referencecommit="f119e740c87918b103140b66b2316ae96f136b0e"
#referencerevision=4138
referencecommit="6b3d7b17a749e03bcbf2cf79bbbb903137298c44"
referencerevision=5235
Re: Freecad 0.16 source.tar.gz out of date?
Linking related post: viewtopic.php?f=4&t=19903
Alone you go faster. Together we go farther
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs
Please mark thread [Solved]
Want to contribute back to FC? Checkout:
'good first issues' | Open TODOs and FIXMEs | How to Help FreeCAD | How to report Bugs