IFC import, treat FreeCAD, King_merged

[yorik]

hehe wow... impressive!
We should really think a bit about how to manage all the complexity of those rich IFC models... I'm usually not very satisfied with the dumb and too rigid Building->Floor->Objects hierarchy of ifc...

[bernd]

... I'm usually not very satisfied with the dumb and too rigid Building->Floor->Objects hierarchy of ifc...

+1 All the elemets in ifc-files have lots of attributes which could be used to filter. At least the ifcbuildingelement itself.

To be honest, currently I'm happy if ALL elemtes are imported without errors. By the way since the model is downloaded from the internet the screenshots may be used somewhere.

[bernd]

the first hing it already does. You must enable debug messages in Arch IFC preferences options

I allready tried that option but for me it doesn't make any difference at all.

[bernd]

the first hing it already does. You must enable debug messages in Arch IFC preferences options

I allready tried that option but for me it doesn't make any difference at all.

On my FreeCAD latest from source the debugmessages are shown only if a ifc is opend from pythonkonsole using

Code: Select all

importIFC.open(file)

. If the gui (mouse) is used to open a ifc, the debugmessages are not shown.

[yorik]

Ah, maybe you must activate the "redirect python output" by right-clicking on the output window...

[bernd]

Ah, maybe you must activate the "redirect python output" by right-clicking on the output window...

How about some little update in importIFC.py?

Code: Select all

hugo@weide:~/Documents/projekte--ifc/freecad/development/snapshot/free-cad-code/build$ diff Mod/Arch/importIFC.py ../src/Mod/Arch/importIFC.py
151c151
<                         nobj = makeStructure(obj.id,obj.type,shape,n)
---
>                         nobj = makeStructure(obj.id,shape,n)
396c396
< def makeStructure(entity,ifctype,shape=None,name="Structure"):
---
> def makeStructure(entity,shape=None,name="Structure"):
409,417c409
<             if ifctype == "IfcBeam":
<               structure.Role = "Beam"
<             elif ifctype == "IfcColumn":
<               structure.Role = "Column"
<             elif ifctype == "IfcSlab":
<               structure.Role = "Slab"
<             elif ifctype == "IfcFooting":
<               structure.Role = "Foundation"
<             if DEBUG: print "made structure object  ",entity,":",structure,"  IfcBuildingElement  ",ifctype
---
>             if DEBUG: print "made structure object  ",entity,":",structure
419d410
< 

[bernd]

and this one:

Code: Select all

diff Mod/Arch/ArchWall.py   ../src/Mod/Arch/ArchWall.py
33,36d32
< # Possible roles
< Roles = ["Wall"]
< 
< 
64d59
<     obj.Role = "Wall"
395,396d389
<         obj.addProperty("App::PropertyEnumeration","Role","Arch",
<                         str(translate("Arch","The role of this structural element")))
403d395
<         obj.Role = Roles

[yorik]

Thanks! I added you first changes. The wall roles I didn't, because I prefer not to add things that have no real reason to exist yet... At the moment it's very easy to convert a wall to struct or vice-versa, so I think the current needs (for example structural walls) are fulfilled. If we find a reason to have roles for walls, I add it.

Next time, if you want to see your name in the official freecad commits (and therefore become an official freecad developer), think about making a git branch

[bernd]

Next time, if you want to see your name in the official freecad commits (and therefore become an official freecad developer), think about making a git branch

One more reason to use git.

...The wall roles I didn't, ... If we find a reason to have roles for walls, I add it.

I would like to do mass calculation of different elements. Really simple example.

Code: Select all

beam = 0
column = 0
foundation = 0
slab = 0
wall = 0
for o in objectlist:
  if hasattr(o,'Role'):         
    if o.Role == 'Beam':
      beam += 1
    elif o.Role == 'Column':
      column += 1
    elif o.Role == 'Foundation':
      foundation += 1
    elif o.Role == 'Slab':
      slab += 1
    elif o.Role == 'Wall':
      wall +=1
print('Folgende Elemente gefunden:')
print('Beam', beam)
print('Column', column)
print('Foundation', foundation)
print('Slab', slab)
print('Wall', wall)
print('Sum', beam+column+foundation+slab+wall)
print('')

But I'm fine anyway. We need to think about this attribute stuff either. I allready run into trouble again. Slab for ifcexport but special Element for structural calculation and mass calculation. !!! May be keep it in mind until the export works ...

[bernd]

gave this huge file (see first topic post) another try in FreeCAD but it failed to import the file

I played with python but I'm not able to find a shape I'm able to import. There must be something strange has happened ...

Code: Select all

ifcfile = '/home/hugo/Desktop/210_King_Merged.ifc'
import ifcopenshell, os
import Part

from ifcopenshell import geom
settings = ifcopenshell.geom.settings()
settings.set(settings.USE_BREP_DATA,True)
settings.set(settings.SEW_SHELLS,True)
settings.set(settings.USE_WORLD_COORDS,True)

f = ifcopenshell.open(ifcfile)
f.by_type('IfcPerson')
f.by_type('IfcBuildingElementProxy')

p = f.by_id(3213449)
r = p.Representation
print p, '\n', r

cr = ifcopenshell.geom.create_shape(settings, p)

I can try any IfcProduct. I get no brep ...