Search found 306 matches

Go to advanced search

by furti
Mon Sep 16, 2019 5:05 pm
Forum: Developers corner
Topic: FreeCAD Renderer Workbench improvements
Replies: 18
Views: 663

Re: FreeCAD Renderer Workbench improvements

That looks pretty cool :) @furti I've added support for version 2 of luxcore's file format (SDL). If you're planning to add support for it, I can do a quick backport so you'll be able to use it with your code. I will not have the time to implement textures for all renderers now. But making your impr...
by furti
Sat Sep 14, 2019 10:19 am
Forum: Developers corner
Topic: FreeCAD Renderer Workbench improvements
Replies: 18
Views: 663

Re: FreeCAD Renderer Workbench improvements

Could someone create a specific branch in the Render WB to explore that? My fork of the Render Workbench already contains such a branch: https://github.com/furti/FreeCAD-render/tree/renderer-fixes To test the textures you also have to use this branch of the ArchTexture Workbench: https://github.com...
by furti
Fri Sep 13, 2019 4:58 am
Forum: Users Showcase
Topic: SlopedPlanesMacro
Replies: 110
Views: 18396

Re: SlopedPlanesMacro

As far as i can see it is still the same as before?
https://gitlab.com/damianCaceres/slopedplanes

A combination of macro and workbench?

But when it is possible to get gitlab repositories into the addon manager, it would be good to get the code of the original author.
by furti
Thu Sep 12, 2019 4:23 pm
Forum: Developers corner
Topic: FreeCAD Renderer Workbench improvements
Replies: 18
Views: 663

Re: FreeCAD Renderer Workbench improvements

Now I can show you what I had in mind with texturing. This are two cubes in FreeCAD. One with an Texture applied, the other without a texture. freecad_cubes.png When rendering the two cubes with the Render Workbench we get a result like this. There are no textures applied render_cubes_no_texture.png...
by furti
Mon Sep 09, 2019 6:04 pm
Forum: Developers corner
Topic: FreeCAD Renderer Workbench improvements
Replies: 18
Views: 663

Re: FreeCAD Renderer Workbench improvements

My own suggestion would be to use FreeCAD materials for just as much as possible. They should contain everything we need: different color values, specific values for shaders, texture paths, etc Storing everything inside the material makes things easy that is true. But i think we loose a lot of flex...
by furti
Mon Sep 09, 2019 10:49 am
Forum: Developers corner
Topic: FreeCAD Renderer Workbench improvements
Replies: 18
Views: 663

Re: FreeCAD Renderer Workbench improvements

Sorry but i don't get the point of your post. It would make things a lot easier for me if it were that simple. What should be simple? And what is complicated right now? I'm not going to write a separate function for all those parameters. When i look at blenders principeld bsdf it has 17 inputs. Wher...
by furti
Mon Sep 09, 2019 5:54 am
Forum: Developers corner
Topic: FreeCAD Renderer Workbench improvements
Replies: 18
Views: 663

Re: FreeCAD Renderer Workbench improvements

At the moment, I'm thinking about using a wrapper class around the material dictionary Using the material dictionary directly will not work. Not everything is inside the core material. Textures for example are handled by a external workbench. So we need a dedicated RenderMaterial that can have more...
by furti
Mon Sep 09, 2019 5:04 am
Forum: Developers corner
Topic: FreeCAD Renderer Workbench improvements
Replies: 18
Views: 663

Re: FreeCAD Renderer Workbench improvements

Having a dict to store the data in the class is also fine for me. But i would not use a "getFloat("xxx")" approach but instead add dedicated "getXxx()" methods like "getRoughness()" "getTextureFile()" and so on. Because this gives a dedicated API. Otherwise i can do stuff like "getFloat("TextureFile...
by furti
Sun Sep 08, 2019 1:23 pm
Forum: Developers corner
Topic: FreeCAD Renderer Workbench improvements
Replies: 18
Views: 663

Re: FreeCAD Renderer Workbench improvements

But I really don't understand why you pinged me for comments after you've issued a PR instead of before As i wrote in the PR it is intented for discussion. Its easier to discuss actual code than simply talk about it. :) Github makes it possible to write comments Into the code and stuff like this. T...
by furti
Sun Sep 08, 2019 7:45 am
Forum: Developers corner
Topic: FreeCAD Renderer Workbench improvements
Replies: 18
Views: 663

FreeCAD Renderer Workbench improvements

I created a pull request that refactors some things in the Renderer Workbench in preparation to incorporate textures from the ArchTexture workbench. The pull request is here and should be the base for discussions if this goes in the right direction. https://github.com/FreeCAD/FreeCAD-render/pull/13 ...

Go to advanced search