Search found 88 matches

Go to advanced search

by Wsk8
Thu Apr 02, 2020 5:43 pm
Forum: Path/CAM
Topic: Drilling Beyond the bottom of a hole
Replies: 14
Views: 253

Re: Drilling Beyond the bottom of a hole

Russ4262 wrote:
Thu Apr 02, 2020 2:14 pm
Will you also fix line 444:

Code: Select all

        #xRotRad = 0.01

It should read:

Code: Select all

        zRotRad = 0.01
The original was a typo, the `x` needed to be a `z`. It was commented out because it was a copy of the code two lines up.
Done
#3303
by Wsk8
Thu Apr 02, 2020 2:56 pm
Forum: Path/CAM
Topic: Drilling Beyond the bottom of a hole
Replies: 14
Views: 253

Re: Drilling Beyond the bottom of a hole

Yes, i will link you to the PR

br
by Wsk8
Thu Apr 02, 2020 1:15 pm
Forum: Path/CAM
Topic: Drilling Beyond the bottom of a hole
Replies: 14
Views: 253

Re: Drilling Beyond the bottom of a hole

Are you sure?
https://github.com/FreeCAD/FreeCAD/blob ... oleBase.py

Here the line 336:

Code: Select all

finDep = holeBtm
which causes the error is still there.

br
by Wsk8
Thu Apr 02, 2020 1:03 pm
Forum: Path/CAM
Topic: Drilling Beyond the bottom of a hole
Replies: 14
Views: 253

Re: Drilling Beyond the bottom of a hole

Hello russ,
this was probably my PR. If i remember correctly, i placed this line for correct depth calculation in 4th axis. Didn't realized it also affected custom depths.

br
by Wsk8
Thu Apr 02, 2020 12:53 pm
Forum: Path/CAM
Topic: Drilling Beyond the bottom of a hole
Replies: 14
Views: 253

Re: Drilling Beyond the bottom of a hole

Hello,
the problem lies in PathCircularHoleBase.py. Comment out line 336. I remove it and make a PR.

br
by Wsk8
Sun Mar 29, 2020 3:57 pm
Forum: Path/CAM
Topic: Commit "Merge pull request #3188 from Schildkroet/grbl-post" removed "enable spindle" command in gcode
Replies: 10
Views: 207

Re: Commit "Merge pull request #3188 from Schildkroet/grbl-post" removed "enable spindle" command in gcode

Gauthier wrote:
Sun Mar 29, 2020 3:36 pm
ping
Can you make a pull request?
This should fix the problem:

Code: Select all

    isActive = PathUtil.opProperty(obj, 'Active')
    if isActive == False:
        continue
by Wsk8
Sun Mar 29, 2020 3:56 pm
Forum: Path/CAM
Topic: Commit "Merge pull request #3188 from Schildkroet/grbl-post" removed "enable spindle" command in gcode
Replies: 10
Views: 207

Re: Commit "Merge pull request #3188 from Schildkroet/grbl-post" removed "enable spindle" command in gcode

OK, found out, the tool change problem only occurs if you use the default tool. If you use only your created tools, it works as expected. Seems to be a problem with tool tables etc.

mfg
by Wsk8
Sun Mar 29, 2020 3:51 pm
Forum: Path/CAM
Topic: Commit "Merge pull request #3188 from Schildkroet/grbl-post" removed "enable spindle" command in gcode
Replies: 10
Views: 207

Re: Commit "Merge pull request #3188 from Schildkroet/grbl-post" removed "enable spindle" command in gcode

@Gaunthier No, disabled operations are not outputted. This two lines prevent only output of comments and coolant (maybe also tool change). But the op itself is already discarded before. ping ping There seems to be a general problem in output. I did some test and found out these bad behaviours: - Onl...
by Wsk8
Sun Mar 29, 2020 3:25 pm
Forum: Path/CAM
Topic: Commit "Merge pull request #3188 from Schildkroet/grbl-post" removed "enable spindle" command in gcode
Replies: 10
Views: 207

Re: Commit "Merge pull request #3188 from Schildkroet/grbl-post" removed "enable spindle" command in gcode

Hello,

does following tool changes are output for you? I made some tests now and for me only the first M6 is output, but not the following. It seems there is something else wrong.

mfg
by Wsk8
Sun Mar 29, 2020 3:09 pm
Forum: Path/CAM
Topic: Commit "Merge pull request #3188 from Schildkroet/grbl-post" removed "enable spindle" command in gcode
Replies: 10
Views: 207

Re: Commit "Merge pull request #3188 from Schildkroet/grbl-post" removed "enable spindle" command in gcode

I looked into it and it seems that these operations do not have an "active" attribute at all, so they are overlooked in the post processor. For the moment you can go to "Mod\Path\PathScripts\post\grbl_post.py" and delete these lines (around 263ff): if not PathUtil.opProperty(obj, 'Active'): continue...

Go to advanced search