Search found 3412 matches

Go to advanced search

by abdullah
Sun May 24, 2020 2:03 pm
Forum: Pull Requests
Topic: PR #3456 - Adding chamfer angle field to PartDesign
Replies: 75
Views: 2339

Re: PR #3456 - Adding chamfer angle field to PartDesign

Thanks for the fix! Double shame on me as integrator in practice :oops: :oops: :oops: The best part of a merge is usually to look after for Werner's critical eye: Unable to align spin boxes? This is how: 53dbc5fc2df5cea4fad95be8aed4fc6206e10db6 Integrator not attentive enough to good UI practices? ...
by abdullah
Sun May 24, 2020 1:32 pm
Forum: Pull Requests
Topic: [Sketcher] projection of (implemented)
Replies: 8
Views: 365

Re: [Sketcher] projection of (implemented)

It was a pleasure to make the calculations, I had not done any in ages… Not son fun to debug my sleep deprived typos un close variable names… By the way, opencascade has a projection library, which does not make the right calculations I believe. Anyone ever worked with them upstream? 'Cause it woul...
by abdullah
Sun May 24, 2020 6:32 am
Forum: Pull Requests
Topic: PR #3456 - Adding chamfer angle field to PartDesign
Replies: 75
Views: 2339

Re: PR #3456 - Adding chamfer angle field to PartDesign

armandas wrote:
Sat May 23, 2020 11:01 pm
By the way, this can be closed now.

https://tracker.freecadweb.org/view.php?id=1204
Done!
by abdullah
Sun May 24, 2020 6:30 am
Forum: Developers corner
Topic: Dynamically Hideable Property Status
Replies: 18
Views: 663

Re: Dynamically Hideable Property Status

I tried this example on my locally built version where I have restored the old behaviour of the property editor. When entering the two Python code lines to add the property and hide it afterwards it shows the same behaviour as in your animation. What the screencast shows is not the desirable behavi...
by abdullah
Sun May 24, 2020 5:30 am
Forum: Help on using FreeCAD
Topic: Undo in Sketcher creates inconsistent constraints
Replies: 36
Views: 730

Re: Undo in Sketcher creates inconsistent constraints

8d821fe5f On Undo/Redo I don't think the class PropertyConstraintList should trigger the signals signalConstraintsRemoved() or signalConstraintsRenamed() because the correct values for the PropertyExpressionEngine will be restored from the transaction system of the document. For me the above files ...
by abdullah
Sat May 23, 2020 10:33 am
Forum: Pull Requests
Topic: PR #3456 - Adding chamfer angle field to PartDesign
Replies: 75
Views: 2339

Re: PR #3456 - Adding chamfer angle field to PartDesign

armandas wrote:
Wed May 20, 2020 11:38 am
Abdullah, any progress?
Thank you very much for contributing to FreeCAD. :)

I have just merged the functionality. :D

Keep it coming ;)
by abdullah
Sat May 23, 2020 6:45 am
Forum: Pull Requests
Topic: PR #3456 - Adding chamfer angle field to PartDesign
Replies: 75
Views: 2339

Re: PR #3456 - Adding chamfer angle field to PartDesign

Hi everyone! I have reviewed it and added a commit with some minor changes, mostly relating to not hiding properties but making then read-only (as per Werner's suggestion): https://github.com/FreeCAD/FreeCAD/pull/3499/commits/61d74091fd2e2853eb09a3fa0698f71e5432cb55 Any legacy chamfer defaults to t...
by abdullah
Fri May 22, 2020 5:39 pm
Forum: Pull Requests
Topic: PR #3456 - Adding chamfer angle field to PartDesign
Replies: 75
Views: 2339

Re: PR #3456 - Adding chamfer angle field to PartDesign

I wouldn't go so far to add or remove them on request. Usually you have opened the appropriate task panel and there you won't even see what happens to a property under the hood. If you prefer to directly work with the property editor and want to make sure that a user cannot change an inactive prope...
by abdullah
Thu May 21, 2020 5:25 am
Forum: Help on using FreeCAD
Topic: Undo in Sketcher creates inconsistent constraints
Replies: 36
Views: 730

Re: Undo in Sketcher creates inconsistent constraints

chrisb wrote:
Wed May 20, 2020 8:22 pm
Glad to see it's reproducable, and much more glad to see you having a look!
I am still debugging. The funny thing is that is you name your constraints, the thing works perfectly. Just name your angle "myangle" and your constraint "myconstraint" and it works... keep debugging...

Go to advanced search