Search found 5 matches

Go to advanced search

by heewa
Fri May 14, 2021 5:18 pm
Forum: Developers corner
Topic: How to handle failures during Document Save
Replies: 0
Views: 1076

How to handle failures during Document Save

While I was investigating and fixing Issue 4098 (FreeCAD should not exit if unable to rename backup file to project file while exiting), I came across a few failure scenarios in the codepaths for saving a Document which don't error out, but probably should. The two cases that seemed obvious to me, a...
by heewa
Fri May 14, 2021 12:36 am
Forum: Developers corner
Topic: Issue fix + 2 related but separate changes
Replies: 4
Views: 549

Re: Issue fix + 2 related but separate changes

Oh, it's not that I've decided, I just wondered about the process. I'll start with a PR next time. Thanks!
by heewa
Thu May 13, 2021 11:52 pm
Forum: Developers corner
Topic: Issue fix + 2 related but separate changes
Replies: 4
Views: 549

Re: Issue fix + 2 related but separate changes

Sure, here you go: Fix app quitting despite failing to save project (fix for Issue 4098) Abort save when unable to finish Fix lost filename in err msg As a side question, isn't this exactly what Pull Requests do - put up code submissions for consideration & discussion? Would it work to just star...
by heewa
Thu May 13, 2021 10:36 pm
Forum: Developers corner
Topic: Issue fix + 2 related but separate changes
Replies: 4
Views: 549

Issue fix + 2 related but separate changes

I believe I have a fix for Issue 4098 (FreeCAD should not exit if unable to rename backup file to project file while exiting) . While debugging that, I also made two related changes that feel separate. How should I handle these? Normally I'd just throw up Pull Requests and figure it out in the discu...
by heewa
Mon May 10, 2021 5:59 pm
Forum: Developers corner
Topic: Bug in Start workspace
Replies: 2
Views: 391

Bug in Start workspace

I've experienced a bug in the Start workspace, where if you have a "custom folder" (labeled "show additional folder" in the Start screen of preferences), the python code for the module throws an exception, doesn't load, and shows an empty white screen instead. I actually already ...

Go to advanced search