I fixed the UnitTest failure, it is a following on work on your pep8. It is mergeable to upstream master. it is on my new branch: fembodyconstraint https://github.com/qingfengxia/FreeCAD/tree/fembodyconstraint Merge branch 'fembodyconstraint' of https://github.com/berndhahnebach… Commits on Feb 11, ...

It has been fixed by some one, it is not shown in github webpage history https://github.com/FreeCAD/FreeCAD/blob/master/src/Mod/Fem/Gui/TaskFemConstraintFluidBoundary.cpp 2) yes there is a bug fix for my fluidboundary, do you suggest splitting it out for pull request directly to master by myself? ht...

your generall constraints are improvements we should get into master. About a time line ... I do not know, we it is ready ... I will have another look before february. I will separete the fixes commit and add it to my next PR. We might need to change the unit tests. I will have a look at this too. ...

I will have a look today and tomorrow to solve it. thank you. error: cannot pass objects of non-trivially-copyable type ‘std::string {aka class std::basic_string<char>}’ through ‘...’ Base::Console().Error("Fluid boundary recomputationg failed for boundaryType `%s` \n", boundaryType); I guess the er...

thank you Bernd, for the pep8 and code review. 1) what do you think on the feature/code quality? Do you have a timeline for this feature to be merged? How can we work together on this feature, e.g. I want to push some fix to your branch, what should I do? # I will rename my branch with the same name...

Happy new year 2019! ========================= ## features Last year, I proposed a generalised body source (gravity, acceleration, heat source, ...) and generalised initial value for any variable, to reduce code duplication. why? InitialValue is not important for linear elastic problem, but very use...

update on Cfd workbench for the year 2018. Cfd workbench will be in maintenance mode, I do not have enough spare time to support feature development. However, I will make Cfd workbench work in stable FreeCAD release like v0.17, and later 0.18, etc. You can fire bug at my https://www.github.com/qingf...

mzagozdzon wrote: ↑

Mon Nov 05, 2018 12:06 am

it refers to a function in CfdTools.py, which should be there
import CfdTools
self.__class__.Icon = CfdTools.getModulePath()

Cfd workbench only works with WSL on win10. I have a brief test on win10, limited by my time

CFD module now works with windows 10 v1803, since wsl output can passed back to caller process.
CFD git will be update soon, with platform installation guide.

I should soon test CFDworkbench it again on FreeCAD 0.17, make Fenics and OpenFOAM in CFD module work with stable 0.17 release.