segFirst and segLast should be taken from the connecting vertices instead of derived from the first and last parameter You're right. With this change, your test is handled successfully: --- a/src/Mod/Part/App/modelRefine.cpp +++ b/src/Mod/Part/App/modelRefine.cpp @@ -472,7 +472,9 @@ bool wireEncirc...

Hi Jim,

implementing this in master would be the same amount of work, again, because the changes to Polarpattern in the development branch are so big that I can't just merge in the code. And since selection of sketch axes is not overly useful for PolarPattern, I don't think its worth it.

Jan

Hi Werner,

you're right I should have said that it needs to go into jriegel's dev-assembly branch. Its based on that.

Jan

Hi,

this branch has two commits to PartDesign:

https://github.com/jrheinlaender/FreeCA ... partdesign

1. Bugfix that didn't allow exiting the dialog of most Transformed features
2. Allow selecting sketch axes in Polarpattern, same as in LinearPattern and Mirrored

Jan

Hi Jim, well it seemed to work but now I just tried opening the file again (attached here) every second time I open it, it crashes FreeCAD, and when it doesn't crash i get an error message in the report view. Support shape is empty! I don't get the crash but I do get the message. The shape in questi...

Hi Jim, I think logari81 implemented this code so I won't say anything about consistency here. But what's really important is not the origin of the sketch (IMHO you should always constrain your sketch to other geometry in such a way that the origin doesn't matter) but the rotation of the sketch coor...

Hi Jim, thanks for all the details. this is the Assembly branch I have compiled jriegel/dev-assembly And does the LinearPattern work correctly on that branch you mentioned??? Up to quitting the dialog with "OK" ? But if you want to define a centre of rotation somewhere on the surface that ...

Hi Jim, but being an edge it only allows 2 items in the polar array and is hence just a mirror. how that? I can select any amount of rotated copies? I implemented selecting the "sketch axis 0" like in the other Linear Pattern but I won't do the sketch point now because it is a bigger chang...

Have you tested the dev-assembly development branch? I think its already implemented there. PartDesign has been enhanced a lot in the development branch so if you are mssing anything in Partdesign you should first look whether it isnt already there.

Hi, it's a precision problem of the file. At least two points are not coincident enough for the comparison with Precision::Confusion() in wireEncirclesAxis(): x=-337.29371510726173 y=-7.9718459295211588 z=-23.654626678766586 and x=-337.29371497646372 y=-7.9718437308356371 z=-23.65462654797377 Just f...