Search found 1300 matches

Go to advanced search

by realthunder
Mon Apr 03, 2017 7:38 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6576

Re: #619 Made TreeView stable

And you will get a performance boost on this loop. But there are other places which needs performance improvement. This is mostly because we need to take care about the new PartDesign. I am sure this is going to help, but that doesn't negate the problem wmayer exposed. And I am really curious of wh...
by realthunder
Mon Apr 03, 2017 7:37 pm
Forum: Part Design module development
Topic: Propose to change App::Part Tree View behavior
Replies: 5
Views: 981

Propose to change App::Part Tree View behavior

The current App::Part (and Body for that matter), behaves differently than other type of objects in the Tree View. For other objects, their children in the tree view control their own visibility independent of the parent. App::Part (actually GeoFeatureGroup), on the other hand, overrides the visibil...
by realthunder
Mon Apr 03, 2017 6:53 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6576

Re: #619 Made TreeView stable

Yep, it is happening on my Windows, too. Six minutes now, still no response. Ahh...I hate Windows. It's probably Qt's fault though. I'll try to avoid take all children and see.
by realthunder
Mon Apr 03, 2017 6:38 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6576

Re: #619 Made TreeView stable

By drag'n'drop into the FreeCAD main window. Reading and transferring the STEP is fast (which isn't influenced by the tree) but when adding the part objects to the part container then this step is very slow (something like O(n^2) I guess). I just drag and drop, and it is fast. In Debug mode, it too...
by realthunder
Mon Apr 03, 2017 6:23 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6576

Re: #619 Made TreeView stable

Even debug build is fast. What OS are you using?
by realthunder
Mon Apr 03, 2017 6:10 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6576

Re: #619 Made TreeView stable

Thanks for looking at this issue. Unfortunately your patch doesn't change anything. The load time of the STEP file is still at ~15 minutes. That's odd. You're right, it didn't make a difference, because I reverted the change and it is still fast on my machine! How did you load the file, by just ope...
by realthunder
Mon Apr 03, 2017 5:08 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6576

Re: #619 Made TreeView stable

wmayer wrote:Here it is.
It is because of the cyclic check on adding object. This is the worst case I've predicated, all children first. But obviously I am wrong about the performance impact. Only 900 object, and it's that slow. I've submitted the fix.
by realthunder
Mon Apr 03, 2017 4:25 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6576

Re: #619 Made TreeView stable

wmayer wrote:Today I found a major performance regression with the new tree view. In issue #1999 you will find the file FreeCadProblem.step which takes 15 minutes to load in release mode.
Mantis is down at the moment. Could you please post the step file here, or if it is too big, send it to my email?
by realthunder
Sun Apr 02, 2017 9:14 am
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6576

Re: #619 Made TreeView stable

This is not due to the presence of 2 bodies: it's the result of Body001 not being hidden as it should. Think of a Part Chamfer applied to a part: after the Chamfer, its parent (what you call "child", but IMO it's the other way around) is automatically hidden. This should be the case here I can see ...
by realthunder
Sun Apr 02, 2017 8:54 am
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6576

Re: #619 Made TreeView stable

I'm sorry but I find your reply confusing The logic you find incorrect lies in PartDesign. Before my patch, the same thing happens, that is, when you create a boolean of Body001, it is NOT removed from 'Part'. So, 'Part' is still effective displaying TWO Body001, you can try on your FC that reverte...

Go to advanced search