Search found 1396 matches

Go to advanced search

by realthunder
Sat Mar 18, 2017 8:03 am
Forum: Users Showcase
Topic: Optics in FreeCAD
Replies: 25
Views: 20405

Re: Optics in FreeCAD

Got an image of some stuff through the lens! On AMD Radeon 7700 and with regular mouse, CADRays is behaving much much better, and makes a nice rendering faster. :o That's very impressive! I actually saw this post long time ago, and was hoping at that time I may some day venture into optics. Unfortu...
by realthunder
Sat Mar 18, 2017 7:05 am
Forum: Path/CAM
Topic: PathGui: ViewProviderPath visual enhancement #625
Replies: 16
Views: 1657

PathGui: ViewProviderPath visual enhancement #625

Hello fellow Pathers, I've just submit a patch for ViewProviderPath with the following enhancement, Enabled preselect Shows GCode command and movement direction when preselected Support single/multi-stepping using property 'StartIndex' and 'ShowCount' Screenshot from 2017-03-18 14-51-42.png You are ...
by realthunder
Thu Mar 16, 2017 3:21 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6715

Re: #619 Made TreeView stable

visit each children recursively (that's factorial n! maybe?) n! !?? If so, it's awful, since factorial of just 13 is already over 1G. And a factorial of 20 will take about 100 years to traverse. Oops, I mean 1+2+3..+n, not multiple, n(n+1)/2. This is the case where all child items are loaded before...
by realthunder
Thu Mar 16, 2017 11:05 am
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6715

Re: #619 Made TreeView stable

:lol: Maybe it can be made faster by going the other way around? i.e. when adding an object as child of something, and withdrawing it from root, look up the ultimate parent of something and check if it is the child being added? This way, the performance penalty is proportional to depth of tree, whic...
by realthunder
Thu Mar 16, 2017 10:31 am
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6715

Re: #619 Made TreeView stable

It may, as it looks like tree update is fired for every change to a property... So maybe just leave it alone for now? The cyclic check only happens when a free item (i.e. an item at document root) is newly claimed, which already has children. The check needs to visit all its children. That's the on...
by realthunder
Thu Mar 16, 2017 10:00 am
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6715

Re: #619 Made TreeView stable

I'll have a look at what's going on, because I now have a feeling it's not your code that hangs. It is kinda of. It actually hangs inside Qt::TreeWidgetItem.addChild. They don't bother checking cyclic reference either. And for a good reason, as it may be a potentially expensive operation. I added t...
by realthunder
Thu Mar 16, 2017 4:14 am
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6715

Re: #619 Made TreeView stable

And another example with same result, that can actually happen for real. Hmm... It's easy for me to fix this up by extra checking, and just not create item for this kind of scenario. But it can't prevent cyclic dependency, and it is still there. There bound to be other problems, e.g. if DAGView is ...
by realthunder
Wed Mar 15, 2017 4:52 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6715

Re: #619 Made TreeView stable

DeepSOIC wrote:I caught the crash in debugger.
Yep, stack frame 26, Tree.cpp:1006, the assertion failure. I've removed that assertion. Please sync and try again.
by realthunder
Wed Mar 15, 2017 4:45 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6715

Re: #619 Made TreeView stable

DeepSOIC wrote:Oh, no :cry: it just crashed again...
Did it crashed at the same line number? It's an assertion failure. That assertion is probably incorrect. I've removed it. Please sync the branch and try again.
by realthunder
Wed Mar 15, 2017 4:07 pm
Forum: Archived Pull Requests
Topic: #619 Made TreeView stable
Replies: 67
Views: 6715

Re: #619 Made TreeView stable

DeepSOIC wrote:False alarm. After clean build, no crashes so far.
-_-; wish there is a wiping sweat emoticon.

On the other hand, I'll be surprised if this patch isn't causing a bunch of problems here and there.

Go to advanced search