Search found 102 matches

Go to advanced search

by aapo
Fri Nov 02, 2018 4:29 pm
Forum: Developers corner
Topic: [Fixed] Recent Change to Selection? maybe Boost::Signals2??
Replies: 15
Views: 791

Re: [solved] Recent Change to Selection? maybe Boost::Signals2??

I wrote a patch along my hypothesis, and the blocking seems to work with it. FreeCAD_TechDraw_blockSelection.patch.txt There are few things to note: I changed the blocking in Selection.cpp slightly, but as wmayer said it's probably not necessary. There was one case in TechDraw, where saveSvg() block...
by aapo
Fri Nov 02, 2018 1:28 pm
Forum: TechDraw
Topic: [Bug, SOLVED] Unable to make dimensions in FreeCAD TechDraw
Replies: 14
Views: 966

Re: [Bug?] Unable to make dimensions in FreeCAD TechDraw

Hmm, that's unfortunate, unless the fix will be found swiftly. However, the proposed patch seems to totally remove selection blocking from MDIViewPage::selectQGIView(App::DocumentObject *obj, const bool isSelected) . Shouldn't the selection blocking instead be also made nested with the "bool ok" tac...
by aapo
Fri Nov 02, 2018 11:14 am
Forum: Developers corner
Topic: [Fixed] Recent Change to Selection? maybe Boost::Signals2??
Replies: 15
Views: 791

Re: [solved] Recent Change to Selection? maybe Boost::Signals2??

I agree that they should have the same effect, but I wasn't sure if both of the approaches actually worked correctly in practice. I was thinking that the object "connectSelection" would maybe not have any true information about the blocking state after the blocking semantics were put into separate o...
by aapo
Fri Nov 02, 2018 9:21 am
Forum: Developers corner
Topic: [Fixed] Recent Change to Selection? maybe Boost::Signals2??
Replies: 15
Views: 791

Re: [solved] Recent Change to Selection? maybe Boost::Signals2??

Hi, I was reading through the patch and was wondering why in the patch "bool ok" is taken from connectSelection? @@ -68,9 +67,9 @@ bool SelectionObserver::blockConnection(bool block) { bool ok = connectSelection.blocked(); if (block) blocker.block(); I would have thought that this should be taken fr...
by aapo
Thu Nov 01, 2018 6:44 pm
Forum: TechDraw
Topic: [Bug, SOLVED] Unable to make dimensions in FreeCAD TechDraw
Replies: 14
Views: 966

Re: [Bug?] Unable to make dimensions in FreeCAD TechDraw

Yep, I just now finished compiling after git revert f898eafd64f88902ea1916b01303705b3baa2c46 and the commit reverts cleanly with no problems. The resulting FreeCAD binary has working TechDraw dimensioning again, so I can confirm that it's the boost::signals -> boost::signals2 upgrade that causes the...
by aapo
Thu Nov 01, 2018 5:48 pm
Forum: TechDraw
Topic: [Bug, SOLVED] Unable to make dimensions in FreeCAD TechDraw
Replies: 14
Views: 966

Re: [Bug?] Unable to make dimensions in FreeCAD TechDraw

Great! That should limit the problem into just 14 commits, which I hope will make it easy to see exactly what commit causes the problem, even without git bisection. My money is in the boost.signals to boost.signals2 upgrade in commit 3858b17 triggering some old stale bug with object activation. Othe...
by aapo
Thu Nov 01, 2018 8:57 am
Forum: TechDraw
Topic: [Bug, SOLVED] Unable to make dimensions in FreeCAD TechDraw
Replies: 14
Views: 966

[Bug, SOLVED] Unable to make dimensions in FreeCAD TechDraw

Hi, When I try to add a vertical (or any other) dimension in FreeCAD TechDraw, the program asks "Select an object first", although I definitely have an edge selected. This seems to happen at least for me in recent Git builds (0.18.15xxx) for both Linux and Windows, and it renders the latest TechDraw...
by aapo
Wed Oct 31, 2018 11:35 pm
Forum: TechDraw
Topic: [Bug, SOLVED] Multiple elliptic cuts on different depth levels
Replies: 18
Views: 1115

Re: [Bug?] Multiple elliptic cuts on different depth levels

I'll revisit this subject slightly, as I believe there's another bug in the TechDraw module. With the same FCSTD example file as above, if one selects "Iso Count = 1" from the UI, the ellipses are again malformed: FreeCAD_elliptic_shape_techdraw_iscircle2_bug.png I wrote a small patch, where the cru...
by aapo
Tue Oct 30, 2018 7:06 pm
Forum: TechDraw
Topic: [Bug, SOLVED] Multiple elliptic cuts on different depth levels
Replies: 18
Views: 1115

Re: [Bug?] Multiple elliptic cuts on different depth levels

Thanks for the fix! I can confirm that the fix in github also works for me, and I get basically the same, expected result after rebuilding.
by aapo
Mon Oct 29, 2018 10:55 pm
Forum: TechDraw
Topic: [Bug, SOLVED] Multiple elliptic cuts on different depth levels
Replies: 18
Views: 1115

Re: [Bug?] Multiple elliptic cuts on different depth levels

I tested again on Linux with OCC version 7.3.0, and the same problem occurs. OS: Debian GNU/Linux testing (buster) Word size of OS: 64-bit Word size of FreeCAD: 64-bit Version: 0.18.15099 (Git) Build type: Release Branch: master Hash: 1538a14eca0879be3d223930f7e5f78d4a24691c Python version: 2.7.15+ ...

Go to advanced search