Search found 47 matches

Go to advanced search

by marktaff
Tue Oct 28, 2014 3:56 am
Forum: Developers corner
Topic: Sketcher: Ellipse support
Replies: 713
Views: 93080

Re: Sketcher: Ellipse support

I have fixed the minor bug I spoke about earlier, and also begun debugging the constraint conflicts on small circular ellipse. https://github.com/marktaff/FreeCAD_sf_master/commit/5c3e20af1a95c860112289dcdda54ea99778bc3a See the commit message and grep for "@bug" in the diff for an overview of the i...
by marktaff
Thu Oct 23, 2014 1:46 pm
Forum: Developers corner
Topic: Sketcher: Ellipse support
Replies: 713
Views: 93080

Re: Sketcher: Ellipse support

I see you have introduced: #include <qdebug.h> I personally put any debug staff between conditional compilation blocks. Do not take this as a change request. Just an observation... Change requests are only ordered by the real integrator (e.g. Werner) :) This is a Qt app, so qDebug() is already avai...
by marktaff
Mon Oct 20, 2014 5:13 pm
Forum: Developers corner
Topic: Sketcher: Ellipse support
Replies: 713
Views: 93080

Re: Sketcher: Ellipse support

If we are to pick one method then I would pick Abdullah's. But I don't claim to be an expert here so I am happy to be told I am wrong, if I am wrong. :) This is my logic. 1) General drawing/engineering/manufacture principles. In most general cases the location of any circle or arc is defined by, or...
by marktaff
Mon Oct 20, 2014 4:54 am
Forum: Developers corner
Topic: Sketcher: Ellipse support
Replies: 713
Views: 93080

Re: Sketcher: Ellipse support

No. It is ok and integrated. You may want to take a look just before the "doCommand" call. I have integrated there the creation of internalalignment geometry on creation of ellipse. If you think something should be improved, please clone the aforementioned branch "skt2_marktaff_creation", do your c...
by marktaff
Sun Oct 19, 2014 10:55 pm
Forum: Developers corner
Topic: Sketcher: Ellipse support
Replies: 713
Views: 93080

Re: Sketcher: Ellipse support

Mark if you are on a Ubuntu variant, try installing a little application called "git cola". It is a simple gui. It greatly eases push/pull/rebase/etc.. and management of remotes and branches. When you pull or push with git cola it asks "from/to where". To run git cola, just navigate to you git dire...
by marktaff
Sun Oct 19, 2014 9:29 pm
Forum: Developers corner
Topic: Sketcher: Ellipse support
Replies: 713
Views: 93080

Re: Sketcher: Ellipse support

Well, I've got my code done, but of course my old nemesis git is rearing its ugly head. :? I cloned abdullah's code: https://github.com/marktaff/FreeCAD_sf_master/tree/skt2_rebase_DeepSOIC_attempt ETA: Don't bury the lede, Mark! The above link now points to the public code, thanks to lame_r on #free...
by marktaff
Sat Oct 18, 2014 8:24 pm
Forum: Developers corner
Topic: Sketcher: Ellipse support
Replies: 713
Views: 93080

Re: Sketcher: Ellipse support

Just wanted to touch base. I have both ellipse construction methods implemented in the handler class, I just need to integrate it into the UI similar to the circle. I'll probably be done later today or Sunday, depending on coding time available.
by marktaff
Thu Oct 16, 2014 1:55 pm
Forum: Developers corner
Topic: Sketcher: Ellipse support
Replies: 713
Views: 93080

Re: Sketcher: Ellipse support

One thing about "slow" compilation times. Most of you will know it: 1. Kdevelop per default has 1 core compilation (look in the project options to configure more cores if you have a multiple core procesor). 2. If you compile with normal make from the terminal, pass the -j X (e.g. -j 4), to use mult...
by marktaff
Wed Oct 15, 2014 2:01 pm
Forum: Developers corner
Topic: Sketcher: Ellipse support
Replies: 713
Views: 93080

Re: Sketcher: Ellipse support

P.S.: Mark, if you did not start again with github, please pull my branch "skt2_rebase_DeepSOIC_attempt" and introduce your code there. When you are ready just commit it to your github and let me know, so that I make it into the branch that will be pull-requested. If you already started with skt2, ...
by marktaff
Tue Oct 14, 2014 11:28 am
Forum: Developers corner
Topic: Sketcher: Ellipse support
Replies: 713
Views: 93080

Re: Sketcher: Ellipse support

If anyone has interest, I have forked Mark's branch to my repo when compiling, and it's still there . Hope Mark won't be angry at me :roll: . Nope, not angry. I'm not really the angry type. :-) The code I backed up is a tiny bit further along than what was last comitted to my repo, as far as the re...

Go to advanced search