Search found 176 matches

by Fat-Zer
Tue Sep 01, 2015 1:25 pm
Forum: Assembly
Topic: App::Part question
Replies: 59
Views: 19872

Re: App::Part question

unfortunatly I don't realy have time the next weeks to check your changes. sure, no hurry here... anyway it's not finished yet... One thought I had recently: you may want to pull in the changes I've done in my branch, as it will get only more complicated with more large changes in your branch. I wa...
by Fat-Zer
Tue Sep 01, 2015 2:53 am
Forum: Assembly
Topic: App::Part question
Replies: 59
Views: 19872

Re: App::Part question

Finished App::Origin's refactoring... If somebody wants to look through: https://github.com/Fat-Zer/FreeCAD_sf_master/tree/AMM-partRework It took a bit more time when I suspected... Next tasks: Gui::ViewProvider{Plane,Line} and App::Part PS: I want to rename App::Line->Axis any agrees/disagrees? PPS...
by Fat-Zer
Tue Sep 01, 2015 1:25 am
Forum: Developers corner
Topic: App::Document something strange around the undoing
Replies: 1
Views: 486

App::Document something strange around the undoing

There is something strange about the App::Document undoing stuff... Reading Document::addObject() and Document::remObject() I assumed that d->activeTransaction is set during normal transaction and d->activeUndoTransaction is set during undoing, but it seams DocumentP::activeTransaction never gets se...
by Fat-Zer
Mon Aug 31, 2015 8:30 pm
Forum: Assembly
Topic: App::Part question
Replies: 59
Views: 19872

Re: App::Part question

Ok, about the delete issue: forbiding the deletion works great in the view providers level as expected... But the cascade deletion of objects does not... I strongly don't like the Stefan's implementation I reverted, so I'll better add a yet another callback like I've done for setupObject()... Now I'...
by Fat-Zer
Mon Aug 31, 2015 10:12 am
Forum: Assembly
Topic: App::Part question
Replies: 59
Views: 19872

Re: App::Part question

Are you sure? not absolutely... it definitely should work when deleting from the Gui with delete press, but I'm not sure about other ways... will think about it one more time... But this restricts the origin to known classes it can be in, so it would become impossible for any workbench to reuse the...
by Fat-Zer
Mon Aug 31, 2015 9:17 am
Forum: Assembly
Topic: App::Part question
Replies: 59
Views: 19872

Re: App::Part question

But how would you prevent the deletion in a viewprovider context? return false from onDelete(), haven't tried yet, but should work fine And if you change things to allow the prevention of a deletion, than you have the exact same problem after copying, don't you? just check if plane/axis/origin is p...
by Fat-Zer
Sun Aug 30, 2015 8:44 pm
Forum: Assembly
Topic: App::Part question
Replies: 59
Views: 19872

Re: App::Part question

I'm a bit stuck with how to encapsulate the creation of Origin object and all it's axises/planes into one action. IMO the situation when it's a caller responsibility to call some setup() method after the creation of an object to create it's childrens that are required to operate correctly is unaccep...
by Fat-Zer
Sat Aug 29, 2015 2:08 pm
Forum: Developers corner
Topic: Crash FreeCAD: SoBase.cpp:190: SoBase::SoBase(): Assertion `(SoBase::classTypeId != SoType::badType())
Replies: 11
Views: 3553

Re: Crash FreeCAD: SoBase.cpp:190: SoBase::SoBase(): Assertion `(SoBase::classTypeId != SoType::badType())

I can't reproduce your crash (I suppose because I have non-debug build of Coin and/or FreeCAD), but I have another: When selecting the DWire: Program received signal SIGSEGV, Segmentation fault. 0x00007ffff6fdad18 in App::Enumeration::getEnumVector() const () from /usr/lib64/freecad-9999/lib64/libFr...
by Fat-Zer
Fri Aug 28, 2015 9:30 pm
Forum: Assembly
Topic: App::Part question
Replies: 59
Views: 19872

Re: App::Part question

Yesterday's experiment about rebasing Part on a DocumentObjectGroup was successfull enough: 168 additions and 440 deletions. And now it's possible to add features to parts with drug&drop... May still require some polish... https://github.com/Fat-Zer/FreeCAD_sf_master/tree/AMM-partRework Now I'm ...
by Fat-Zer
Thu Aug 27, 2015 8:56 am
Forum: Assembly
Topic: App::Part question
Replies: 59
Views: 19872

Re: App::Part question

I currently don't know wihch parts are douplicate, but both your solutions sound actually worse than a simple code duplication :) Is the amount of duplication that large that a redesign is justified? It's not really... but both GeoFeatureGroup and ViewProviderGeoFeatureGroup becomes copy-paste of t...