wmayer wrote:In modelRefine.cpp line 474, there is an error:

Code: Select all

if (faceTest.State() == TopAbs_EXTERNAL)

TopAbs_EXTERNAL is an TopAbs_Orientation. So, you actually have to use either TopAbs_IN, _OUT, _ON, _UNKNOWN.

this is still set to TopAbs_EXTERNAL. did you not change this or did I accidentally change it back?

yorikvanhavre wrote:

tanderson69 wrote:Does this mean that you guys are going to be interfacing with a sourceforge hosted git repository?

Exactly!

IMHO. This is a mistake......but I will shut up now.....I promise

jriegel wrote:So I would say I push next week the first version into git!

Does this mean that you guys are going to be interfacing with a sourceforge hosted git repository?

There might be some perks in git vs svn, but the only reason to go through a switch would be to get the distributed environment. If you watch the linus at google video, he says that if they spend the whole day talking about the distributed nature of git that would be fine with him. Sorry to beat a d...

But you know that you can implemented a function object to provide the less operator? No I didn't. thanks. ...10 min for the cube example and now it's ~40 sec on my machine. That sounds about right. It went from 15-20 minutes to 2-3 minutes here. The biggest help was setting up the shape maps for t...

Some low hanging fruit. With this it is somewhere between 2 and 3 minutes for your meshed box. There is more. Tried using std::map before but the TopoDS_shape classes don't overload the less than operator. Didn't pursue it at the time, but now I put in some toptools maps and it pays off pretty well....

tanderson69 wrote:I am confused!

not anymore. good catch.

This region growing algorithm was easy to implement for our mesh data structure because for each facet we save the adjacent facets. For the B-REP model I don't know how topological information is internally stored. But anyway I don't see this optimization as a must. what optimizations do you see as...

Okay, thanks for the explanations. I supppose all the commits you do in the branches get added to the master when you merge? I mean with their description messages? Yes. What would happen if I do a dcommit from inside the branch, instead of inside the master, do you know? I have used git to track s...

This workflow seems a little unusual too me. you should be doing the commits while you were on your "draft" branch then merge them to the master. With that workflow there was no reason for the branching or the merging as the only commit you made was on your local master branch. Should be m...