Search found 2190 matches

by realthunder
Mon Sep 02, 2019 1:00 pm
Forum: Developers corner
Topic: Code review of merged Link3 branch
Replies: 75
Views: 21560

Re: Code review of merged Link3 branch

Violating such a basic rule makes it a nightmare to maintain a bigger project in the long run. If not, the modification will be something like replacing obj.Shape access with Part.getShape(obj), which is essentially what this patch does. I think it is very much doable without writing something Wern...
by realthunder
Mon Sep 02, 2019 11:48 am
Forum: Archived Pull Requests
Topic: PR #2475: Expression syntax extension
Replies: 60
Views: 34817

Re: PR #2475: Expression syntax extension

ah ... that's a pity. In your -asm3 branch it is possible. Is it very difficult to implement it here also ? Is there a technical hurdle ? May-be there would be other use-cases than Asm4 The technical difficulty is to make it secure. Calling into object opens up a lot more attack surface. I'll work ...
by realthunder
Mon Sep 02, 2019 10:59 am
Forum: Archived Pull Requests
Topic: PR #2475: Expression syntax extension
Replies: 60
Views: 34817

Re: PR #2475: Expression syntax extension

EDIT: does this allow to call methods on objects ? Like : No, you cannot call methods. The equivalent expression will be Group.<<Box.>>.Placement.Matrix * Group.<<$Cube.>>.Placement.Matrix ^ -1 The result is a matrix, but you can bind it directly to a Placement property.
by realthunder
Mon Sep 02, 2019 10:58 am
Forum: Open discussion
Topic: App::Link: the big merge
Replies: 145
Views: 43522

Re: App::Link: the big merge

The latest update brought improvements in Expression auto complete: now the labels of objects can be used and a completion list is shown. However, this ends after the constraints. Especially the named constraints are not offered. It used to be like that: Already when typing something like SketchXXX...
by realthunder
Mon Sep 02, 2019 4:02 am
Forum: Developers corner
Topic: Code review of merged Link3 branch
Replies: 75
Views: 21560

Re: Code review of merged Link3 branch

Thanks for the detailed review, wmayer. You are a great project leader without doubt. 50cefc5104d62fc2d1ba87c7df79a28ff6a6ef5c Console: improve console logging facility Why is the if-check in ConsoleSingleton::Log reversed? Oops, that must be a typo or something. aa7d780f5d6ea492d8c379d810fff420f3ff...
by realthunder
Mon Sep 02, 2019 3:04 am
Forum: Developers corner
Topic: Why does App::MaterialObjectPython needs a Shape?
Replies: 26
Views: 4067

Re: Why does App::MaterialObjectPython needs a Shape?

mlampert wrote: Mon Sep 02, 2019 3:01 am What's the status on this? Is the null Shape property here to stay?

There are quite a few exceptions in Path due to this and I need to know how to proceed.
There should be no null shape any more in upstream. Please report if otherwise.
by realthunder
Mon Sep 02, 2019 3:01 am
Forum: Developers corner
Topic: Code review of merged Link3 branch
Replies: 75
Views: 21560

Re: Code review of merged Link3 branch

chrisb wrote: Sun Sep 01, 2019 5:16 pm Is this the place to add more regressions?
- Autocompletion of expressions is not working
There is a fix for auto complete in recent accepted PR. Which version have you tried. Maybe you can report to the big merge thread first.
by realthunder
Mon Sep 02, 2019 12:03 am
Forum: Assembly
Topic: Assembly 4 workbench
Replies: 1346
Views: 902973

Re: Assembly 4 workbench

Zolko wrote: Sun Sep 01, 2019 3:06 pm hum, thinking of it, I see the problem: you can't propose the commit if it's untested, and I can't test Asm4 because I can't compile Pyside2/Shiboken.
I have already submitted the PR here
by realthunder
Sat Aug 31, 2019 7:47 am
Forum: Archived Pull Requests
Topic: PR #2475: Expression syntax extension
Replies: 60
Views: 34817

PR #2475: Expression syntax extension

PR link here Changes include: Add internal function list/tuple(). Spreadsheet range expression can be expanded to list or tuple, e.g. list(A1:A10) Use Python number protocol in OperatorExpression, so you can doing something like matrix * vector, rotation * vector, or formatted string like <<This is ...
by realthunder
Thu Aug 29, 2019 10:31 pm
Forum: Assembly
Topic: Assembly 4 workbench
Replies: 1346
Views: 902973

Re: Assembly 4 workbench

So what's really missing is the possibility, in the ExpressionEngine, to make operations on Placements (or on matrices, quaternions, vectors, I don't know). If you could extract that part from your version of the ExpressionEngine parser and make a PR for v19 would be great. Yes, I know. If you are ...