Search found 4863 matches

by abdullah
Thu Nov 09, 2023 7:38 pm
Forum: Developers corner
Topic: [User input] Sketcher - ToolWidget
Replies: 121
Views: 50054

Re: [User input] Sketcher - ToolWidget

Cool addition. I think it has the potential. But we need a use case. I just published it so we are aware the code exists and it is a possibility. * IMO better use 'steady_clock' than 'system_clock'. The former is guaranteed to be monotonic, which will prevent weird things to happen when eg. system ...
by abdullah
Thu Nov 09, 2023 7:33 pm
Forum: Developers corner
Topic: [User input] Sketcher - ToolWidget
Replies: 121
Views: 50054

Re: [User input] Sketcher - ToolWidget

Polyline is not ready if someone want to handle it, its quite a complex tool. This is just a cheeky comment... but after all the handlers you have written, you could consider that one as a treat as "the last one". Polyline is a very powerful tool. Yet, it has the bad habit of creating red...
by abdullah
Wed Nov 08, 2023 5:51 pm
Forum: Developers corner
Topic: [User input] Sketcher - ToolWidget
Replies: 121
Views: 50054

Re: [User input] Sketcher - ToolWidget

I had this work half done and decided to finish it: https://github.com/abdullahtahiriyo/FreeCAD_sf_master/tree/_DrawSketchHandle_LongPress_MouseRightButton_ It basically extends the framework to be able differentiate a short right mouse click from a long right mouse click, and for example, show a co...
by abdullah
Wed Nov 08, 2023 4:35 pm
Forum: Developers corner
Topic: [User input] Sketcher - ToolWidget
Replies: 121
Views: 50054

Re: [User input] Sketcher - ToolWidget

Ok. Let's go for another round. Most of the issues reported should be fixed. - The OVPs (On View Parameters, the boxes with arrows), by default, only appear from dimensioning constraints. Before they appeared for positioning too. I would like to have some feedback on this mode . - The visibility of ...
by abdullah
Tue Nov 07, 2023 6:03 pm
Forum: Developers corner
Topic: [User input] Sketcher - ToolWidget
Replies: 121
Views: 50054

Re: [User input] Sketcher - ToolWidget

I will make the changes to my current PRs. For your changes will you make the changes of existing tools in your own PR? Or do you want me to cherry pick your code and add to my PR? Please take https://github.com/FreeCAD/FreeCAD/pull/11294 into consideration before merging something else though. Tha...
by abdullah
Tue Nov 07, 2023 12:57 pm
Forum: Developers corner
Topic: [User input] Sketcher - ToolWidget
Replies: 121
Views: 50054

Re: [User input] Sketcher - ToolWidget

To do it properly, I need to pass the changes of spinbox focus via the framework. This means that: - onViewParameters[OnViewParameter::Sixth]->setSpinboxValue(handler->thickness); + setOnViewParameterValue(OnViewParameter::Sixth,handler->thickness); Because you have many handlers written, you can au...
by abdullah
Tue Nov 07, 2023 12:47 pm
Forum: Developers corner
Topic: [User input] Sketcher - ToolWidget
Replies: 121
Views: 50054

Re: [User input] Sketcher - ToolWidget

Ah well I have already made a good part of it. The preference part. I did not implement where the preference act though, which is probably the greatest part of it. I'll let you handle it then and see what issue is remaining. I think there is only the spinbox position issuefrom the german post. With...
by abdullah
Mon Nov 06, 2023 8:04 pm
Forum: Developers corner
Topic: [User input] Sketcher - ToolWidget
Replies: 121
Views: 50054

Re: [User input] Sketcher - ToolWidget

And there is a difference between constructive criticism, and antagonistic behavior. There is. However, the most valuable skill you may develop over your professional life is to be able to take everything that is worth it, no matter how it comes packaged. Which is true. And why I removed this comme...
by abdullah
Mon Nov 06, 2023 7:58 pm
Forum: Developers corner
Topic: [User input] Sketcher - ToolWidget
Replies: 121
Views: 50054

Re: [User input] Sketcher - ToolWidget

I will make an option to disable this feature. Both for the widget and the OnViewParameters. Please do not. I have been working this evening. It is almost there. I should provide something tomorrow. It does not make sense to repeat effort. We need to find the sweet spot. It will come. Please, conce...
by abdullah
Mon Nov 06, 2023 7:51 pm
Forum: Developers corner
Topic: [User input] Sketcher - ToolWidget
Replies: 121
Views: 50054

Re: [User input] Sketcher - ToolWidget

Too many toolbar icons, even in drop-down toolbars, make it difficult to find what you want. I keep it short: What is here hard to find (and that is the big long constraint bar)? Even other CADs, that have for each kind of operation a single tool in the toolbar, it is easy to find, they are (in wil...