FreeCAD Forum

reference: https://forum.freecadweb.org/viewtopic. ... 60#p385635

abdullah wrote: ↑

Thu Apr 09, 2020 4:36 pm

DeepSOIC wrote:...

Any recommended way to clear (empty) the parameterStore?

Create a new one. Clearing is not supported, as there may be ParameterRefs that still refer to it.

GIL discussion: https://forum.freecadweb.org/viewtopic.php?f=10&t=45076

I presume that if we don't, incrementing and decrementing of reference counters in different threads can cause race conditions, so GIL is required. Right?

Now to the gil. This is rather painful, as any use of Py::Object (creation, reassignment, destruction) must happen with GIL engaged, because I assume that changing reference count is a Py API call, and Non-Python created threads When threads are created using the dedicated Python APIs (such as the t...

abdullah wrote: ↑

Thu Apr 09, 2020 3:30 pm

If it is relevant, I may try to make an interface to change it from Python.

That would be nice, but if it gets difficult, maybe it's worth having a separate branch with new sketcher code...

abdullah wrote: ↑

Thu Apr 09, 2020 2:11 pm

I pushed a second fix.

Thanks, all compiling fine now.

BTW, is it possible to quickly get the old sketcher in our development branch? I want to use sketches to quickly mock up some geometry for testing with console, and the fact that sketcher is broken really gets in the way of that...

I have pushed a fix for makeParameters. I'll open a discussion on this topic...

It seems to help adding this: Base::PyGILStateLocker lock; before calling the type. This should probably be placed in a variety of places in constraintsolver, I have to figure out where exactly... Now I get a new crash, in the destructor of TaskDialog, when I close the sketch: TaskDialog::~TaskDialo...