Search found 1361 matches

by freman
Thu Jan 14, 2021 11:18 am
Forum: Path/CAM
Topic: slot on curve
Replies: 38
Views: 1256

Re: slot on curve

re. comments on PR. discussion of whether " Extend Path Start " should be applied to the other end of a slot when selecting Reverse Direction https://github.com/FreeCAD/FreeCAD/pull/4253 Here an extension is defined to cut outside the work and ensure a full width on entry. Zero end extension mean ha...
by freman
Thu Jan 14, 2021 12:59 am
Forum: Path/CAM
Topic: slot on curve
Replies: 38
Views: 1256

Re: slot on curve

updated test file for PR.
by freman
Fri Jan 08, 2021 9:43 am
Forum: Path/CAM
Topic: slot on curve
Replies: 38
Views: 1256

Re: slot on curve

Don't worry. If it bothered me I would not have got involved. I've learnt a bit from your code snips which is useful. Thanks.

Be aware that the slot tool is relatively new and is certainly not finished. If my PR gets merged, it will have a few less oddities that it did.
by freman
Fri Jan 08, 2021 8:57 am
Forum: Path/CAM
Topic: slot on curve
Replies: 38
Views: 1256

Re: slot on curve

see my edit above. Do you see any outstanding issue here now with better understanding?
by freman
Fri Jan 08, 2021 8:35 am
Forum: Path/CAM
Topic: slot on curve
Replies: 38
Views: 1256

Re: slot on curve

Thanks, that looks rather worrying on the face of it. Can I suggest that you start a new thread here about this defect, since this is totally separate from the slot issue this thread is about. BTW these examples of scripting will be very useful for creating tests in general. I've never had enough sp...
by freman
Thu Jan 07, 2021 9:44 pm
Forum: Path/CAM
Topic: slot on curve
Replies: 38
Views: 1256

Re: slot on curve

These bugs you say are happening could be very important. Could you provide a complete code snippet which will demonstrate the 84 degree angle and the bugs in ValueAt ?
by freman
Thu Jan 07, 2021 7:57 pm
Forum: Path/CAM
Topic: slot on curve
Replies: 38
Views: 1256

Re: slot on curve

It's not my code beyond what is in the PR. It is credited to Russ. IIRC the bound box was only used in a specific case. What are the assumptions and errors you refer to. Apart from unfinished features ( like offset from a straight edge ) the only bug I see here now is the collision test is finding s...
by freman
Thu Jan 07, 2021 6:20 pm
Forum: Path/CAM
Topic: slot on curve
Replies: 38
Views: 1256

Re: slot on curve

thanks, a quick scan seems similar to much which is done in the existing code.

What it this providing that is not already there and now working with my PR?
by freman
Wed Jan 06, 2021 2:17 pm
Forum: Path/CAM
Topic: slot on curve
Replies: 38
Views: 1256

Re: slot on curve

@Russ4262 maybe you could test the PR and let me know if you see any quirks.
by freman
Tue Jan 05, 2021 9:55 am
Forum: Path/CAM
Topic: slot on curve
Replies: 38
Views: 1256

Re: slot on curve

HI Russ. Thanks, that was not what I meant but is probably the reply to what I should have asked. I was meaning what determines which end the code regards as vertexes[0] ? The direction the arc was created in, in sketcher, does not seem to affect it , neither does defining a start point ( which it p...