Merging of my Link branch

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
looo
Posts: 1878
Joined: Mon Nov 11, 2013 5:29 pm

Re: Merging of my Link branch

Postby looo » Tue Aug 07, 2018 6:30 am

release 0.8 testing:

- topo-naming / sketcher problem seems to be solved https://forum.freecadweb.org/viewtopic. ... 10#p247084
- test are working for me (I reported the one that is failing for master on linux-systems: https://forum.freecadweb.org/viewtopic.php?f=10&t=30179)
- using draft after running the tests seems to work too.
- loading the wikilab.FCStd went down to 52.4 sec (qt4 / py2)

- there is still a problem with draft-snapping. If a point is selected the end-point-snapping doesn't work.

now compiling with python3...

regarding the merge strategy: I think we really need to know how to proceed. There is no alternative, this branch has to be merged. Else there will be a forked FreeCAD which will replace the master quite soon. And I think everybody will benefit if FreeCAD has only one official branch...
triplus
Posts: 7136
Joined: Mon Dec 12, 2011 4:45 pm

Re: Merging of my Link branch

Postby triplus » Wed Aug 08, 2018 9:41 pm

realthunder wrote:
Mon Aug 06, 2018 11:09 pm
It is enabled by default, for any object. But with the default behavior, it still has to load all the depending object, which is not useful, say, if you put one model per file, all objects of that file is likely to be a long dependency chain. To break that chain, the object needs special implementation, which I outlined in the document, and has Assembly container as a demonstration.
And having the special implementation provided by default makes little sense? And to ditch the approach where results are not all that useful altogether?
As much as I hate to do the repeating work, if wmayer finds it is necessary to split it out, I'll do it.
Fair enough.

P.S. If by any chance the directive won't come in the time frame you would be able to create such PR. I guess just go after the PR and lets see how it will look like and on how to proceed from there on.
dulouie
Posts: 53
Joined: Tue Oct 03, 2017 4:14 pm

Re: Merging of my Link branch

Postby dulouie » Thu Aug 09, 2018 10:22 pm

It's sad that wmayer is still ignoring your request. I don't know the reasons of the conflict but a 'Yes' or a 'No and why" is much better than no answer.

I vote for merge to master.
chrisb
Posts: 9549
Joined: Tue Mar 17, 2015 9:14 am

Re: Merging of my Link branch

Postby chrisb » Thu Aug 09, 2018 11:30 pm

dulouie wrote:
Thu Aug 09, 2018 10:22 pm
It's sad that wmayer is still ignoring your request. I don't know the reasons of the conflict but a 'Yes' or a 'No and why" is much better than no answer.
I'm only guessing, but perhaps there is more to say or it takes considerable time to review.
looo
Posts: 1878
Joined: Mon Nov 11, 2013 5:29 pm

Re: Merging of my Link branch

Postby looo » Fri Aug 10, 2018 2:43 am

I'm only guessing, but perhaps there is more to say or it takes considerable time to review.
Maybe true, but a short statement on how to proceed would be nice.
Jee-Bee
Posts: 1129
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: Merging of my Link branch

Postby Jee-Bee » Fri Aug 10, 2018 7:51 am

chrisb wrote:
Thu Aug 09, 2018 11:30 pm
I'm only guessing, but perhaps there is more to say or it takes considerable time to review.
Is he reviewing... we don't know
Mark Szlazak
Posts: 282
Joined: Tue Apr 04, 2017 6:06 pm
Location: California, USA

Re: Merging of my Link branch

Postby Mark Szlazak » Sat Aug 11, 2018 3:55 pm

Jee-Bee wrote:
Fri Aug 10, 2018 7:51 am
chrisb wrote:
Thu Aug 09, 2018 11:30 pm
I'm only guessing, but perhaps there is more to say or it takes considerable time to review.
Is he reviewing... we don't know
Unless Realthunder changed his mind or I misunderstood one of his more recent posts, he plans one more release by the end of August which I guess he considers adequate enough to merge. Perhaps, wmeyer is waiting until then or he is busy reviewing other FreeCAD or life in general. It would be nice to hear from wmeyer on this.
paullee
Posts: 825
Joined: Wed May 04, 2016 3:58 pm

Re: Merging of my Link branch

Postby paullee » Sun Aug 12, 2018 1:00 am

Hi. Whilst this is way far too technical, the 'feature' for 'consistent / unique identification of sketch edges survive changes' is tested.
Not sure this is directly related here.


Seems working :) Always think this features should solve the problem in Link To External Edge and helps a lot.
(e.g. problem in using sketch as base for architectural layout
- https://forum.freecadweb.org/viewtopic. ... t=external Link between two sketches)

(Other previous related discussions
https://forum.freecadweb.org/viewtopic.php?f=22&t=28575 sketch.Geometry[index].Tag == Unique identification survive changes?
https://forum.freecadweb.org/viewtopic. ... 6&start=50 Sketcher feature request: "publish" any element)


(FreeCAD-asm3-20180811-aee619a0-a2a5d69.glibc2.17-x86_64.AppImage)

Test
2 Sketches
- 1st with a few edges
- 2nd with 3 External Edges from the 1st
- 2nd with 2 edges coincident with the External Edge end/start points

Then
- Delete 2 edges with edge index before the selected 'external edge' and after

Used to be Behaviour (Undesirable)
- The edges indexes are shifted
- 2nd Sketch will have External Edges 'shifted'
- Edge 'build' on the External Edges will change

Now Behaviour (Desirable + Intuitive)
- The edge 'new kind of index' seem consistent
- 2nd Sketch will NOT have External Edge 'shifted'
- Edge 'build' on the External Edges will NOT change

Thinking now the External Edges are kind of 'construction geometry'... could these be selected by users and turn directly into edge / 'kind of' Export feature?

2 SKETCHES
Screenshot from 2018-08-12 08-25-30.png
Screenshot from 2018-08-12 08-25-30.png (235.4 KiB) Viewed 170 times
Screenshot from 2018-08-12 08-25-49.png
Screenshot from 2018-08-12 08-25-49.png (212.59 KiB) Viewed 170 times
1st SKETCH with Edges Deleted - No impact on 2nd Sketch (Good!)
Screenshot from 2018-08-12 08-49-31.png
Screenshot from 2018-08-12 08-49-31.png (209.82 KiB) Viewed 170 times
Attachments
Test_ REALTHUNDER_ASM3_ Sketch_ExternalLink_ BEFORE.fcstd
(18.59 KiB) Not downloaded yet
Test_ REALTHUNDER_ASM3_ Sketch_ExternalLink_ AFTER_ 1.fcstd
(16.31 KiB) Not downloaded yet
tmolteno
Posts: 4
Joined: Fri Apr 27, 2018 11:40 am

Re: Merging of my Link branch

Postby tmolteno » Sun Aug 12, 2018 11:59 pm

looo wrote:
Tue Aug 07, 2018 6:30 am
There is no alternative, this branch has to be merged. Else there will be a forked FreeCAD which will replace the master quite soon. And I think everybody will benefit if FreeCAD has only one official branch...
Couldn't agree more. When I read an earlier comment complaining that merging this may delay the next stable release, my heart sank because I now think fork is probably the right thing to do. In my opinion, this merge, and assemblies in general are critical. FreeCAD2.org anyone?
User avatar
kkremitzki
Posts: 850
Joined: Thu Mar 03, 2016 9:52 pm
Location: Texas

Re: Merging of my Link branch

Postby kkremitzki » Mon Aug 13, 2018 12:14 am

tmolteno wrote:
Sun Aug 12, 2018 11:59 pm
looo wrote:
Tue Aug 07, 2018 6:30 am
There is no alternative, this branch has to be merged. Else there will be a forked FreeCAD which will replace the master quite soon. And I think everybody will benefit if FreeCAD has only one official branch...
Couldn't agree more. When I read an earlier comment complaining that merging this may delay the next stable release, my heart sank because I now think fork is probably the right thing to do. In my opinion, this merge, and assemblies in general are critical. FreeCAD2.org anyone?
This is probably premature.