[Renderer Workbench] Lighting

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
howetuft
Posts: 16
Joined: Tue Sep 10, 2019 8:16 pm

[Renderer Workbench] Lighting

Postby howetuft » Sun Nov 03, 2019 7:24 pm

Hi everybody!

Playing around with the new Renderer Workbench, I had a feeling we could improve the new Renderer Workbench by adding some lighting functionalities. Here is my proposition:

Problematic:
At the moment, to set lighting in rendering, we rely on renders templates, with 2 flavors for each back-end renderer: standard, sunlight.

The main advantage with templates is that they require no tuning from the user. But there is a major drawback: it is not possible to adapt the lights parameters to the object you want to render, as all lights parameters are set once and for all in the template.

That being said, template is a good approach for sunlight lighting, because sunlight lighting is mostly independent from the object you want to render. And sunlight is naturally suitable for building rendering (arch).

However, there are other rendering situations for which sunlight lighting is not really suitable: part rendering, indoor scene rendering... For those situations, we need to light the scene with lights objects and we need to be able to adapt the lighting parameters to the rendered object. Those parameters encompass:
- number and types of lights
- positions of lights
- powers of lights
- colors of lights
- etc.
So we need mechanisms to do that in the workbench...

For all situations also (part, outdoor arch, indoor arch), we might also want to use image-based lighting (https://en.wikipedia.org/wiki/Image-based_lighting), which can offer some interesting lighting possibilities as well, especially with HDRI images.

Proposition:
My idea would be to add the following capabilities in Render WB:

1. An image-based lighting functionality.
It would allow to add an HDR image to the model, to be exported to the renderer.

2. A few lights objects, accessible via the WB toolbar, that could be added in the render view
In order to preserve the multi-renderer orientation of the workbench, it would consists in a small common subset of lights objects that could be handled by all back-ends renderers, ie:
- Points lights
- Areas lights (as rectangles)
Those objects would be exported to the renderers in the same way as geometry.
Those objects would bear an 'active' property (inactivated lights wouldn't be exported).
Those objects could be grouped in Lights groups, with an 'active' property also.

3. A three-points lighting functionality
As the above #2 functionality may introduce some complexity to non-advanced users, I propose to add a one-click action which would add a standard configuration of lights achieving a classic lighting scheme, the "three-points lighting": see http://www.3drender.com/light/3point.html, https://en.wikipedia.org/wiki/Three-point_lighting, or this blender plugin https://blender-addons.org/tri-lighting-addon.

For all those functionalities, I would replace the present "standard" template with a "dark" (or "flat") template, with no light.


Roadmap:
Collect the feedback from this thread and adapt my proposition.
Make a first implementation of the above ideas with Luxrender renderer.
Generalize to the other renderers once we agree on the result.

--> What would you think about that?
openBrain
Posts: 2394
Joined: Fri Nov 09, 2018 5:38 pm

Re: [Renderer Workbench] Lighting

Postby openBrain » Mon Nov 04, 2019 4:44 pm

There is already an on going effort related to this. ;)
I'll try to find a link.
openBrain
Posts: 2394
Joined: Fri Nov 09, 2018 5:38 pm

Re: [Renderer Workbench] Lighting

Postby openBrain » Mon Nov 04, 2019 4:52 pm

I can't find, but IIRC this was @furti that did that...
furti wrote: Ping
User avatar
furti
Posts: 329
Joined: Mon Nov 27, 2017 5:27 pm

Re: [Renderer Workbench] Lighting

Postby furti » Mon Nov 04, 2019 6:04 pm

Until now there is no lightning Support available i think.


I added customizable lights to the archtexture workbench a while ago http://forum.freecadweb.org/viewtopic.php?t=39031

My goal was to use this information and add this lights to the render workbench.
But cuttently I'm pretty busy planning our house. Maybe you can build on top of this lights and add them to the render workbench.

There is some ongoing effort in enhancing the workbench. https://github.com/FreeCAD/FreeCAD-render/pulls
openBrain
Posts: 2394
Joined: Fri Nov 09, 2018 5:38 pm

Re: [Renderer Workbench] Lighting

Postby openBrain » Mon Nov 04, 2019 7:00 pm

furti wrote:
Mon Nov 04, 2019 6:04 pm
That was exactly the information I was looking for. Thx for pinging the ping. ;)
howetuft
Posts: 16
Joined: Tue Sep 10, 2019 8:16 pm

Re: [Renderer Workbench] Lighting

Postby howetuft » Sat Nov 09, 2019 10:49 am

OK, I'm going to see first how I can use Archtexture features for my purposes!
howetuft
Posts: 16
Joined: Tue Sep 10, 2019 8:16 pm

Re: [Renderer Workbench] Lighting

Postby howetuft » Mon Nov 11, 2019 9:20 pm

Hello all,

As a follow-up to my previous post, I looked at existing code, and below are my conclusions at this stage (all of these are my personal opinions so feel free to comment):

1. Point Lights (PL)

What is reusable from ArchTextures WB:
- PL Creation/Deletion
- PL Placement
- PL Color
- PL Visibility (on/off)

What needs some adaptations:
- PL Power setting: every renderer has its own logic for PL Power configuration, which makes the point tricky: As a consequence, it is not possible to export point lights to the different renderers with the current data structure, which is suitable only for Open Inventor (and POV-Ray, but I think this renderer should not be a target), because of the upper bound constraint.

Therefore I would propose to add a RenderPower attribute to Point Lights (in ArchTextures WB), with the following characteristics:
- In watts (because it is the more precise unit, from a physical point of view)
- With no upper bound (as nothing justify to limit light power)
Then each renderer exporter script would be in charge to convert this value to its renderer's logic.
The renderer exporter would also provide default values for its other parameters (efficiency, size, intensity_multiplier etc.), possibly accessible as object attributes in the Render Project object.
For the internal rendering (in ArchTextures WB), we have to decide whether we keep the current Intensity parameter as a free value or we link it to the new RenderPower parameter (and, in that case, we should decide how we link it).


2. Area Lights (AL)

There is no such functionality in the ArchTextures WB at the moment, but we can add one. My idea would be to use rectangular areas (defined by a center point, 2 sizes parameters (X & Y), a normal vector, and angle of rotation around normal), with color (emissive) and visibility.
However, please note that there is the same Power issue as above, so we must address it for PL before starting anything before starting anything with AL.

3. Image-Based Lighting (IBL)
No such functionality in OpenInventor (and then in ArchTextures WB). Moreover, OpenInventor doesn't know anything about HDR image format, which is required for IBL. Therefore, in my opinion, it can only be implemented in the Render WB, as an attribute to the render project to be exported by the renderer script.

Please feel to comment!
If OK, my plan is to focus first on Point Lights, creating the RenderPower parameter, and adapting the LuxCore exporter...
User avatar
Kunda1
Posts: 5945
Joined: Thu Jan 05, 2017 9:03 pm

Re: [Renderer Workbench] Lighting

Postby Kunda1 » Fri Nov 29, 2019 1:00 pm

Really thorough summary and proposal. Thanks for the effort here, @howetuft
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
howetuft
Posts: 16
Joined: Tue Sep 10, 2019 8:16 pm

Re: [Renderer Workbench] Lighting

Postby howetuft » Fri Nov 29, 2019 1:38 pm

Thank you! I've started to write some lines of code for Point Lights rendering, hope to be able to present something before X-Mas...
Nocturnial
Posts: 27
Joined: Thu Aug 15, 2019 9:42 am

Re: [Renderer Workbench] Lighting

Postby Nocturnial » Mon Dec 02, 2019 6:00 pm

This is mainly for the architecture users, but maybe also put on the list support to export the hosek-wilkie skylight. The major renderers (appleseed, luxcore, blender) already support this.

The user doesn't even need to guess the direction of the sun. Look at https://forum.freecadweb.org/viewtopic.php?t=18587. PySolar can take as input longitude, latitude and time, and it will spit out the correct direction of the sun.

If you want to be extremely precise, I can take a look whether the output of PySolar and hosek-wilkie are compatible with eachother. This is in respect to the apparant (after atmospheric refraction) or real position of the sun. I thought they were but I'm not sure.