Geometric Dimensioning & Tolerancing

Discussions about the development of the TechDraw workbench
lidiriel
Posts: 24
Joined: Sat Dec 21, 2019 9:30 pm
Location: France

Geometric Dimensioning & Tolerancing

Postby lidiriel » Tue Jan 14, 2020 9:48 am

Hi freecad team,

I'm not sure is it the good place to post : but i have create a pull request for a new feature :
It is a small tool : Geometric Dimensioning & Tolerancing (GDT) Reference.
It is my first dev for freecad and a first part for next feature that i would implement : a feature control frame.

https://travis-ci.org/FreeCAD/FreeCAD/builds/636791878
https://github.com/lidiriel/FreeCAD/tree/gdt-reference2

I have rebase the branch gdt-reference2 to master.

what should i do now ?

by

lidiriel
Attachments
gdt_reference2.png
gdt_reference2.png (53.32 KiB) Viewed 482 times
lidiriel
Posts: 24
Joined: Sat Dec 21, 2019 9:30 pm
Location: France

techdraw : new feature

Postby lidiriel » Tue Jan 14, 2020 1:31 pm

Hi freecad team and sorry for my old post in bad thread.

i have create a pull request for a new feature :

It is a small tool : Geometric Dimensioning & Tolerancing (GDT) Reference.
It is my first dev for freecad and a first part for next feature that i would implement : a feature control frame.

https://travis-ci.org/FreeCAD/FreeCAD/builds/636791878
https://github.com/lidiriel/FreeCAD/tree/gdt-reference2

I have rebase the branch gdt-reference2 to master.

what should i do now ?

by

lidiriel
Attachments
gdt_reference2.png
gdt_reference2.png (53.32 KiB) Viewed 396 times
fjullien
Posts: 57
Joined: Wed Jan 17, 2018 7:46 am
Location: France

Re: Geometric Dimensioning & Tolerancing

Postby fjullien » Tue Jan 14, 2020 2:58 pm

Hi,

Your code must first pass travis-CI then you should wait for your code to be reviewed.

Franck.
User avatar
Kunda1
Posts: 6223
Joined: Thu Jan 05, 2017 9:03 pm

Re: techdraw : new feature

Postby Kunda1 » Tue Jan 14, 2020 6:25 pm

Did you submit a PR?
That way the CI can build it and the devs can review the code
Want to contribute back to FC? Checkout:
#lowhangingfruit | Use the Source, Luke. | How to Help FreeCAD | How to report FC bugs and features
CarloGreen
Posts: 5
Joined: Wed May 16, 2018 3:53 pm

Re: Geometric Dimensioning & Tolerancing

Postby CarloGreen » Tue Jan 14, 2020 6:46 pm

I don't know if you are aware that there is an older GD&T toolbox. Maybe you can use some code from the other toolbox to make your life easier.
https://github.com/juanvanyo/FreeCAD-GDT
https://forum.freecadweb.org/viewtopic.php?t=35887
lidiriel
Posts: 24
Joined: Sat Dec 21, 2019 9:30 pm
Location: France

Re: Geometric Dimensioning & Tolerancing

Postby lidiriel » Tue Jan 14, 2020 8:14 pm

Thanks for the link CarloGreen. I will inspect the code to get idea.
wmayer
Site Admin
Posts: 15129
Joined: Thu Feb 19, 2009 10:32 am

Re: techdraw : new feature

Postby wmayer » Tue Jan 14, 2020 11:22 pm

lidiriel wrote:
Tue Jan 14, 2020 1:31 pm
Hi freecad team and sorry for my old post in bad thread.
I have merged your two threads and moved it to the TechDraw development forum.
User avatar
wandererfan
Posts: 3363
Joined: Tue Nov 06, 2012 5:42 pm

Re: Geometric Dimensioning & Tolerancing

Postby wandererfan » Wed Jan 15, 2020 2:45 am

lidiriel wrote:
Tue Jan 14, 2020 8:14 pm
I played with this a bit tonight. It looks good!

Some notes:
- - debug message about "References2D"
- aspect ratio of symbol when text gets longer. Should it turn into rectangle when text length >> text height?
- point of the leader slides past ends of edge. Would be nice if it stopped at the ends, but not a big deal for v1
- label could be just "Reference". the tree is very crowded aready.
- not sure this is a "dimension". "reference" and "balloon" should go into annotations menu some day. maybe a separate gdt menu.
- next sequential reference - see DrawPage.NextBalloonIndex()
lidiriel
Posts: 24
Joined: Sat Dec 21, 2019 9:30 pm
Location: France

Re: techdraw : new feature

Postby lidiriel » Wed Jan 15, 2020 8:21 am

Thanks wmayer : sorry for the extra work.
wmayer wrote:
Tue Jan 14, 2020 11:22 pm
I have merged your two threads and moved it to the TechDraw development forum.
lidiriel
Posts: 24
Joined: Sat Dec 21, 2019 9:30 pm
Location: France

Re: Geometric Dimensioning & Tolerancing

Postby lidiriel » Wed Jan 15, 2020 9:23 am

thanks a lot : i correct these as soon as possible
wandererfan wrote:
Wed Jan 15, 2020 2:45 am
Some notes:
- debug message about "References2D"
- aspect ratio of symbol when text gets longer. Should it turn into rectangle when text length >> text height?
- point of the leader slides past ends of edge. Would be nice if it stopped at the ends, but not a big deal for v1
- label could be just "Reference". the tree is very crowded aready.
- not sure this is a "dimension". "reference" and "balloon" should go into annotations menu some day. maybe a separate gdt menu.
- next sequential reference - see DrawPage.NextBalloonIndex()