uwestoehr wrote: ↑Sat Sep 25, 2021 1:29 am
Hi abdullah, while recompiling sketcher I noticed these warnings you might want to have a look at:
Thanks. I will fix that.
This is because I do not clean before recompiling, so it gets shown only once. If I do not see it that time, I miss it forever. I try to clean and recompile (I use ccache so it is not the end of the world) to catch this things.
If the "e" is not used in the block at all, the best solution is just to delete the "e". That should fix the issue.
Oddly, I have tried to force showing this warning by cleaning the directory and recompiling all and I cannot see the warning in my Kdevelop output. I see other warnings (MPI, progressbar,...), but not the unreferenced local variables one...
abdullah wrote: ↑Sat Sep 25, 2021 7:01 pm
Oddly, I have tried to force showing this warning by cleaning the directory and recompiling all and I cannot see the warning in my Kdevelop output.
Many thanks for the fix.
I encountered the same - KDevelop does not show warnings as MSVC does. Meanwhile I am only with MSVC (and Windows) and is the vast majority of the cases, its warnings are sensible.
In case I encounter more MSVC warnings regarding sketcher I will inform you.
uwestoehr wrote: ↑Sun Sep 26, 2021 2:26 pm
Many thanks for the fix.
I encountered the same - KDevelop does not show warnings as MSVC does. Meanwhile I am only with MSVC (and Windows) and is the vast majority of the cases, its warnings are sensible.
In case I encounter more MSVC warnings regarding sketcher I will inform you.
openBrain wrote: ↑Tue Sep 28, 2021 11:58 am
I compiled your PR and can confirm warning are still present (obviously with some different line numbers) :
Weird that I don't see them. However the warning is real and Werner already fixed it today. I rebased my PR now.