[pull requested] Sketcher: New Features: Symmetry, Copy and 2D Array transformations

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
jmaustpc
Posts: 9566
Joined: Tue Jul 26, 2011 6:28 am
Location: Australia

Re: [testing, final user input] Sketcher: New Features: Symmetry, Copy and 2D Array transformations

Postby jmaustpc » Thu Aug 20, 2015 2:40 pm

abdullah wrote:... I still miss one for the mirroring of a sketch... ;)
How about this one based on the existing "merge sketch" icon... :)
Sketcher_MirrorSketch.svg
(11.97 KiB) Downloaded 93 times
Sketcher_MirrorSketch_22px.png
Sketcher_MirrorSketch_22px.png (1.04 KiB) Viewed 692 times
triplus
Posts: 8706
Joined: Mon Dec 12, 2011 4:45 pm

Re: [testing, final user input] Sketcher: New Features: Symmetry, Copy and 2D Array transformations

Postby triplus » Thu Aug 20, 2015 4:25 pm

abdullah wrote:
abdullah wrote: Then probably you discovered a bug in normal symmetry that was not discovered yet... for the next coding slot...
Yes. You did discover a bug, but neither on the code from yesterday, nor in the normal symmetry code, but in the addition of a list of geometries.

I introduced this bug while improving the Sketcher geometry creation earlier this year (speed up creation of complex objects and construction toggle as a modal tool). This is the message from the commit fixing the bug, if you want to know more:

Code: Select all

commit d9596f896165bd3a3e293294f259f30c810dded7                                                                                                                                                                    
Author: Abdullah Tahiri <abdullah.tahiri.yo@gmail.com>                                                                                                                                                             
Date:   Sat Aug 15 12:15:46 2015 +0200                                                                                                                                                                             
                                                                                                                                                                                                                   
    Sketcher: Bug fix addGeometry list creation and construction lines
    
    ==================================================================
    
    A recent improvement was to allow to create an object (several geometric elements) as construction lines
    by providing an additional parameter as true (that defaults to false).
    
    This introduced a bug, that when a list of geometries mixing construction and normal lines was added (with the parameter as false),
    construction lines would be converted to normal lines.
    
    This fixes the bug.
The fix is in the branch now.

Am I finished or are there outstanding issues?
Great.

P.S. "Copy" probably is the tool user can use for "cloning" sketcher geometry.
cox
Posts: 963
Joined: Wed Nov 26, 2014 11:37 pm

Re: [pull requested] Sketcher: New Features: Symmetry, Copy and 2D Array transformations

Postby cox » Thu Aug 20, 2015 11:05 pm

jmaustpc wrote:How about this one based on the existing "merge sketch" icon...
Realy nice icon :-)
Need help? Feel free to ask, but please read the guidelines first
abdullah
Posts: 3174
Joined: Sun May 04, 2014 3:16 pm

Re: [pull requested] Sketcher: New Features: Symmetry, Copy and 2D Array transformations

Postby abdullah » Thu Aug 20, 2015 11:23 pm

Assuming that somebody does a nice job and not thanking him each time is not right.

My apologies: Thanks Jim for the icons, they are really nice :) :D