Coverity

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
wmayer
Site Admin
Posts: 14068
Joined: Thu Feb 19, 2009 10:32 am

Re: Coverity

Postby wmayer » Sat Sep 03, 2016 1:01 pm

PS: CID 129217 and 129216 should be the last two from the unchecked dynamic_cast type
They are fixed now and few other issues, too.
User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Sun Sep 04, 2016 2:13 pm

wmayer wrote:
PS: CID 129217 and 129216 should be the last two from the unchecked dynamic_cast type
They are fixed now and few other issues, too.
Great! Thank you for all the work, I was thinking we will need about a year to come this far :)

I am doing now a new build from commit 8360, results should be up later today or tomorrow...
User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Mon Sep 05, 2016 3:48 pm

Below is the summary of the latest results. There were a few fixes that seem not to have satisfied the analyse algorithms and are still shown as defects but in general things look much better :)

There are also about 20 issues that were marked to be ignored but are not yet... To successfully ignore an issue the Classification should be set to either “False positive” or “Intentional”. Here is a quite from the Python Coverity Guide https://docs.python.org/devguide/coverity.html
False positive and intentional issues
If the problem is listed under Known limitations then please set the classification to either “False positive” or “Intentional”, the action to “Ignore”, owner to your own account and add a comment why the issue is considered false positive or intentional.
Analysis Metrics
Version: 0.17.8360
Last Analyzed: Sep 04, 2016
Lines of Code Analyzed: 1,906,445
Lines of Code in Selected Components: 1,150,545
Defect Density: 0.17

Defect changes since previous build dated Aug 07, 2016
Newly detected: 20
Eliminated: 381

Defects by status for current build
Total defects: 460
Outstanding: 195
Dismissed: 45
Fixed: 220
User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Wed Sep 14, 2016 4:21 pm

I have reset the 29 issues that were marked as "Action:Fix submitted" in previous build but were not resolved with the new build, back to "Action:Undecided" (changes can always be viewed in the triage history).

I have also marked the issues from this commit https://github.com/FreeCAD/FreeCAD/pull ... cd3fedeca4 as "Action:Fix submitted".
User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Thu Oct 06, 2016 9:11 pm

I did another build from commit 8585 because I wanted to test if results for python will be included, unfortunately they were not and I guess that at the moment mixed (eg C++ and python) analyse is not supported...
User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Tue Apr 18, 2017 11:15 am

User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Sat Jun 03, 2017 6:47 pm

I did a new Coverity build today from commit 11222 : 17 new, 39 fixed... A positive trend :)

84 of the remaining 145 reported issues are in "src/Mod/Robot/App/kdl_cp/", "src/Mod/Path/libarea/" and "src/Mod/Mesh/App/WildMagic4/". Are this something we would review and fix or should I add them on ignore list for now, as we did with other 3rd party code?
User avatar
yorik
Site Admin
Posts: 11044
Joined: Tue Feb 17, 2009 9:16 pm
Location: São Paulo, Brazil
Contact:

Re: Coverity

Postby yorik » Mon Jun 05, 2017 3:06 pm

I think we did fixing here and there in all these 3 libs already, so they are not "pure" anymore (for libarea we could even say that we have the official one, now). But I don't know if someone will ever take the hassle of fixing all the warnings in them...
realthunder
Posts: 940
Joined: Tue Jan 03, 2017 10:55 am

Re: Coverity

Postby realthunder » Tue Jul 04, 2017 7:56 pm

Interesting. I'll take a look at libarea when I have time, maybe in a week or two.
Try Assembly3 (latest version 0.9.1) along with my custom build of FreeCAD at here.
And if you like to show your support, you can find the donate button at here.
User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Sun Nov 12, 2017 6:44 pm

Latest results include python, as it is the first time that python results are included in the analysis, they should be reviewed with some extra care to see how useful they are...