Coverity

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
mlampert
Posts: 1140
Joined: Fri Sep 16, 2016 9:28 pm

Re: Coverity

Postby mlampert » Fri Jul 13, 2018 2:22 am

saso wrote:
Thu Jul 12, 2018 8:56 am
For Path python code there are also issues 168953 and 168942... Could you take a look at the issue 168953 ? Issue 168942 I believe we could mark as "Classification: Intentional & Action: Ignore" ? This would then close all current issues in the Path python code.
I have never used PathSurface (nor is it likely I ever will) so I can't fix 168953, maybe
sliptonic wrote:ping
can take a look.

The same is true for 168942, although that one I should manage to fix without verification.
User avatar
sliptonic
Posts: 1433
Joined: Tue Oct 25, 2011 10:46 pm

Re: Coverity

Postby sliptonic » Sat Jul 14, 2018 3:09 pm

I think this is just a matter of making the test for ocl not conditional.
https://github.com/sliptonic/FreeCAD/co ... a5a1fbdb7d

I'll send a PR unless someone sees an issue.
User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Thu Jul 19, 2018 6:09 am

Thanks, I have marked them all in Coverty as "fix submitted". For issues like 168942, where the intend of that line was basically the same as the reason for detecting it and where the issue by itself is not critical (not a bug), if there is preference to keep such code we can also just mark such issues in the Covertiy as "Classification: Intentional & Action: Ignore".
User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Sun Nov 11, 2018 7:48 am

I was having problems uploading to Coverity so the results for build 0.18.14996 from October are available only now. A new build for November should hopefully be done in the next days...
User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Sat Feb 16, 2019 1:56 pm

Coverity was unavailable for the past few weeks so there was no build analysis of FreeCAD code in January, but now it is back online and new results for build 0.18.15892 are available...
User avatar
saso
Posts: 1179
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: Coverity

Postby saso » Sun Mar 31, 2019 3:02 pm

New report has been created from build 0.19.16291...