PartDesign Hole feature

Here's the place for discussion related to coding in FreeCAD, C++ or Python. Design, interfaces and structures.
triplus
Posts: 9093
Joined: Mon Dec 12, 2011 4:45 pm

Re: PartDesign Hole feature

Postby triplus » Thu Jul 06, 2017 7:06 am

We had much discussions about creating threads in the past and OCC/OCE just isn't there yet to make the experience streamlined. ;)
chrisb
Posts: 21212
Joined: Tue Mar 17, 2015 9:14 am

Re: PartDesign Hole feature

Postby chrisb » Thu Jul 06, 2017 9:44 am

What I would like to have is the type of hole as a data field. Modeling and displaying the hole accordingly seems to be slight overkill.
eivindkvedalen
Posts: 600
Joined: Tue Jan 29, 2013 10:35 pm

Re: PartDesign Hole feature

Postby eivindkvedalen » Tue Jul 25, 2017 9:51 am

Hi all,

I've just submitted PR#898 now, adding a Hole feature to the new PartDesign workbench. There are a few issues left, but should be usable and allowed to be tested by a broader audience now :D.

Eivind
User avatar
saso
Posts: 1378
Joined: Fri May 16, 2014 1:14 pm
Contact:

Re: PartDesign Hole feature

Postby saso » Tue Jul 25, 2017 11:26 am

Wohoo, more work for Kurt :D
Jee-Bee
Posts: 1986
Joined: Tue Jun 16, 2015 10:32 am
Location: Netherlands

Re: PartDesign Hole feature

Postby Jee-Bee » Tue Jul 25, 2017 11:40 am

Exiting finally a descent Hole feature :D
triplus
Posts: 9093
Joined: Mon Dec 12, 2011 4:45 pm

Re: PartDesign Hole feature

Postby triplus » Tue Jul 25, 2017 12:24 pm

Nice to see new features emerging. :)
chrisb
Posts: 21212
Joined: Tue Mar 17, 2015 9:14 am

Re: PartDesign Hole feature

Postby chrisb » Tue Jul 25, 2017 3:23 pm

Thank you very much. What a pity that I don't have any time at the moment for those fun stuff.
User avatar
fosselius
Posts: 348
Joined: Sat Apr 23, 2016 10:03 am

Re: PartDesign Hole feature

Postby fosselius » Tue Jul 25, 2017 5:14 pm

I have compiled it and reviewed some of the code. Looks good. Will play around with it later today.

Update: This is awesome! i do like. I would like to be able to specify the "fit" a bit better (out of ISO spec) as i work with 3d prints and have shrinkage to account for... The code looks neat as well.
peterl94
Posts: 1000
Joined: Thu May 23, 2013 7:31 pm
Location: United States

Re: PartDesign Hole feature

Postby peterl94 » Wed Jul 26, 2017 2:35 am

Great work, eivindkvedalen! This is something I've wanted for a long time.

Is it possible to create a thru hole without specifying depth or is that not implemented yet? The only option I see for depth is "dimension."

OS: Windows 10
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.17.11659 (Git)
Build type: Release
Branch: FeatureHole
Hash: 06bb7d73e5e8ea6510f014fe40b480c060fd947c
Python version: 2.7.8
Qt version: 4.8.7
Coin version: 4.0.0a
OCC version: 7.1.0
Locale: English/UnitedStates (en_US)
eivindkvedalen
Posts: 600
Joined: Tue Jan 29, 2013 10:35 pm

Re: PartDesign Hole feature

Postby eivindkvedalen » Wed Jul 26, 2017 9:18 am

peterl94 wrote:
Wed Jul 26, 2017 2:35 am
Great work, eivindkvedalen! This is something I've wanted for a long time.

Is it possible to create a thru hole without specifying depth or is that not implemented yet? The only option I see for depth is "dimension."
I've updated my PR to include through all now. This was originally implemented (in the same way as in pocket), but I'd forgotten about it. I knew up to face wasn't working, so I disabled both of them before the PR.

Note: The update is a forced update of my branch (this also conveniently starts a new build of the PR). I also rebased it to current master.

Eivind