wmayer wrote: ↑
Fri Jul 14, 2017 8:18 am
By the way, there is an Import module, I think I might just put that stuff there. I think we also need to change Part -> Import STEP code to the Import->Step code, as there is no reason to have 2 differents path to do that.
I don't think the "Import Step" in Part should be removed because:
- it still allows to import/export a rather lightweight data set if needed
- it can be used as reference for the high-level STEP import/export to find out erroneous behaviour
Saying the latter I have found a couple of major regressions with the latest changes:
- when exporting a single object (which is not inside a Part container) placement is lost
Create a cube -> change its placement -> export -> import -> it's now at a different location
- Color information is not read any more in some cases
Load the model asd.stp from this posting https://forum.freecadweb.org/viewtopic. ... 221#p82369 The black and white parts are set to the default color. And even if a manually set the colors again, export and import they don't come back.
Not sure if this is an issue as well but with previous versions it had four objects in the tree view while now it's a single object.
I might be wrong but why does it allow to import/export a rather lightweight dataset that the regular importer/exporter can't do ?
I will check the placement issue you reported, that shall be "easy" to fix.
The Color information is not lost as well as the shapes, this is just an acceleration for "big" model which should happen only on user selectable action. I soon have a fix for that, it is not pushed to master yet, as I am trying to sort out how to handle parameters to STEP importer/exporter, which has been written original 15 years ago.
I loved to see a single code running the step importation, I got some users who are totally lost on why we do have different behavior happening currently. The importer into part is importing shapes without color support at all, while the importer into the file menu is supporting colors and get hierarchies.
I think we shall have ways at least to identify the expected behavior of each action, currently they are named the same way, or we should perhaps propose to the end user within the preference menu if he wants basic import or "full" import, allowing us to keep both codes and avoiding to get end user lost.